ref: Add span filtering to span first (15)#5633
Conversation
…first-6-add-continue-and-new-trace
…na/span-first-7-add-trace-decorator
…-first-8-bucket-based-limits-in-batcher
…-first-8-bucket-based-limits-in-batcher
…tom-sampling-context
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
1 similar comment
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊✅ 2159 passed | ⏭️ 115 skipped | Total: 2274 | Pass Rate: 94.94% | Execution Time: 5m 51s All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 11694 uncovered lines. Files with missing lines (4)
Generated by Codecov Action |
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
looks good, see one non-blocking suggestion
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
In span first, we're introducing a new span filtering
initoption calledignore_spanswhich allows to ignore spans at start time based on name and attributes.ignoredclient report (set viaNoOpStreamedSpan.unsampled_reason).ignore_spans, the whole span tree will be ignored. The implementation achieves this by allowingNoOpStreamedSpans to be set on the scope in this one single case, so that their children can easily determine their segment was dropped.Spec: https://develop.sentry.dev/sdk/telemetry/spans/filtering/#filter-with-ignorespans