Skip to content

tests: Add span streaming tests (13)#5620

Merged
sentrivana merged 89 commits intomasterfrom
ivana/span-first-13-tests
Mar 11, 2026
Merged

tests: Add span streaming tests (13)#5620
sentrivana merged 89 commits intomasterfrom
ivana/span-first-13-tests

Conversation

@sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 9, 2026

Description

Span first on master is finally in a state where we can add meaningful tests.

Longer term, we obviously want to run the whole existing test suite on span first, but this will have to do for now.

These were written entirely by hand, so no need to go looking for nonsensical mocks etc. (hopefully 😆).

Issues

Reminders

@sentrivana sentrivana changed the title tests: Add span streaming tests tests: Add span streaming tests (13) Mar 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Codecov Results 📊

1736 passed | ⏭️ 187 skipped | Total: 1923 | Pass Rate: 90.28% | Execution Time: 2m 21s

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 11851 uncovered lines.


Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review March 9, 2026 14:20
@sentrivana sentrivana requested a review from a team as a code owner March 9, 2026 14:20
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Base automatically changed from ivana/span-first-12-is-segment to master March 11, 2026 08:50
@sentrivana sentrivana enabled auto-merge (squash) March 11, 2026 09:29
@sentrivana sentrivana merged commit 7bf9bb1 into master Mar 11, 2026
175 of 177 checks passed
@sentrivana sentrivana deleted the ivana/span-first-13-tests branch March 11, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants