Skip to content

ref: Add _is_segment() to streaming spans (12)#5619

Merged
sentrivana merged 85 commits intomasterfrom
ivana/span-first-12-is-segment
Mar 11, 2026
Merged

ref: Add _is_segment() to streaming spans (12)#5619
sentrivana merged 85 commits intomasterfrom
ivana/span-first-12-is-segment

Conversation

@sentrivana
Copy link
Contributor

Description

Issues

Reminders

@sentrivana sentrivana changed the title ref: Add _is_segment() to streaming spans ref: Add _is_segment() to streaming spans (12) Mar 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

Codecov Results 📊

13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.66s

All tests are passing successfully.

❌ Patch coverage is 50.00%. Project has 14007 uncovered lines.

Files with missing lines (2)
File Patch % Lines
traces.py 38.80% ⚠️ 153 Missing
_span_batcher.py 31.94% ⚠️ 49 Missing

Generated by Codecov Action

@sentrivana sentrivana marked this pull request as ready for review March 9, 2026 14:19
@sentrivana sentrivana requested a review from a team as a code owner March 9, 2026 14:19
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Base automatically changed from ivana/span-first-11-sampling to master March 11, 2026 08:39
@sentrivana sentrivana enabled auto-merge (squash) March 11, 2026 08:41
@sentrivana sentrivana merged commit 7b2e9df into master Mar 11, 2026
166 checks passed
@sentrivana sentrivana deleted the ivana/span-first-12-is-segment branch March 11, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants