feat: add item_outcomes to TraceItem #174
Open
+171
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds outcome tracking to trace items with data category, quantity, and key_id fields. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
Changes message name from plural to singular since it represents a single outcome. The field name item_outcomes remains plural as it's a repeated list. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
MeredithAnya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ItemOutcomewith following fields:data_category(uint32)quantity(uint64)Adds
key_id(uint64) to theTraceItemA
TraceItemcan have multipleItemOutcomebecause there can be different quantity types. For example,Logitems have outcomes in both thelog_itemandlog_bytecategory.🤖 Generated with Claude Code