feat(metrics): introduce metrics

[Litarnus]

Introducing metrics for PHP!

Metrics have 3 supported types

• Counter
• Gauge
• Distribution

Each of those metrics can be submitted by calling
\Sentry\metrics()->count('test-counter', 1, ['tag' => 'foo'])

It's also possible to attach units:
\Sentry\metrics()->gauge('test-gauge', 10, ['tag' => 'foo'], \Sentry\Metrics\Unit::second())

Up to 1000 metrics can be stored per request. Older metrics are dropped when the limit is reached.

Metrics need to be flushed manually by calling \Sentry\metrics()->flush().

[stayallive]

Code wise the looks good (especially much love for the RingBuffer).

The only thing I'm worried about a bit is that we modify the existing code, namely MetricsUnit and some parameters which is a backwards incompatible break for people that did not yet cleanup their code after we deprecated the previous metrics iteration. Do we feel like that is an acceptable risk? If this is going in 5.x this is a non-issue but the target is master so hence my ask.

[Litarnus]

Code wise the looks good (especially much love for the RingBuffer).

The only thing I'm worried about a bit is that we modify the existing code, namely MetricsUnit and some parameters which is a backwards incompatible break for people that did not yet cleanup their code after we deprecated the previous metrics iteration. Do we feel like that is an acceptable risk? If this is going in 5.x this is a non-issue but the target is master so hence my ask.

Initially we wanted to take the risk but after a longer thought we decided against it. I will revert the Metrics class back to how it originally was and will introduce a TraceMetrics class with the new methods.
I will also add a new alias for Unit -> MetricsUnit since we want to use the unit in different places too.

Thanks for your review, I make this a draft again and ping you once it's updated!

[cleptric]

You could leave this as is.

[Litarnus]

PHPStan doesn't seem to properly resolve aliases so it will complain. But this should work nonetheless since PHP will resolve the alias and treat Unit and MetricsUnit as equivalent.
To satisfy PHPStan we would either have to ignore the error message or subclass it

[stayallive]

Code wise this looks good to me, I haven't dug into the spec much yet but I assume you and Michi got that covered pretty well already!