Repository navigation
Conversation
`sentryCloudflareNitroPlugin` matched the tunnel before `wrapRequestHandler` created the client. No client was current, so the match always failed, the tunnel request got no body, and the app answered it instead of the SDK. The plugin now matches the tunnel inside the `wrapRequestHandler` callback, where the client exists, and passes the body Nitro read only to the tunnel handler. Other requests still get no body, so their bodies stay off their events. The `nuxt-4-cloudflare` tunnel e2e test only checked for a 200, which the app returns too. It now waits for the forwarded envelope, and it fails without this fix. Closes #26364 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
javascript-sdk-gitflow
Bot
requested review from
chargome,
nicohrubec and
s1gr1d
November 13, 2026 16:15
Contributor
size-limit report 📦Compared: 255495c (PR test merge using develop at ad4bbc3) Against: 075093d (develop) · base run #66039
|
Contributor
Optional E2E testsAll optional checks were successful. 7 successful. See the run. Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sentryCloudflareNitroPluginmatched the tunnel beforewrapRequestHandlercreated the client. No client was current, so the match always failed, the tunnel request got no body, and the app answered it instead of the SDK.The plugin now matches the tunnel inside the
wrapRequestHandlercallback, where the client exists, and passes the body Nitro read only to the tunnel handler. Other requests still get no body, so their bodies stay off their events.The
nuxt-4-cloudflaretunnel e2e test only checked for a 200, which the app returns too. It now waits for the forwarded envelope, and it fails without this fix.Closes #26364