Repository navigation
test(nextjs): Cover the server request link of a late trace meta tag - #26357
Merged
Merged
Conversation
The pageload waits at most 10 seconds for the trace meta tag of a resumed shell. When the tag arrives later, the pageload links the server request instead of continuing its trace. Unit tests cover this with fake timers. This adds an E2E test that streams the tag after 10.5 seconds in a real build.
Contributor
size-limit report 📦Compared: 1ee3461 (PR test merge using develop at 9279303) Against: 9279303 (develop) · base run #66015 ✅ Baseline matches: this diff contains only this PR's changes.
|
chargome
approved these changes
Nov 13, 2026
isaacs
approved these changes
Nov 13, 2026
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful. See the run.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an E2E test to both Cache Components apps for a trace meta tag that streams in after the pageload stopped waiting for it. The test checks that the pageload keeps its own trace and links the server request with a
server_requestlink.Why
Until now, only unit tests with fake timers and a hand-written meta tag covered this case. This test runs it against a real streamed response from a production build. The page waits 10.5 seconds: longer than the pageload's 10-second wait, but short enough that the tag arrives before the pageload ends.