Repository navigation
Conversation
Rolldown's default `inlineConst: 'smart'` only inlines constants in conditions, so frequently used `@sentry/conventions` strings end up both as a variable and as literal copies. Inlining everywhere grows the raw output but shrinks the gzipped CDN bundles by ~90-170 B each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 583af81 (PR test merge using develop at 88cc648) Against: 88cc648 (develop) · base run #66002 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 56 successful. See the run.
Successful checks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Rolldown's default
inlineConst: { mode: 'smart' }inlines constants only inside conditions. Frequently used strings, mostly from@sentry/conventions, therefore end up both as a variable and as literal copies:sentry.opis one variable plus about 10 literals inbundle.tracing.min.js. Withmode: 'all'every use becomes a literal. Raw size grows, but gzip handles repeated literals better than variable references, so what users download gets smaller:.min.jsbundlesbundle.min.jsbundle.tracing.min.jsbundle.tracing.replay.min.jsbundle.tracing.logs.metrics.min.jsinlineConst: falsewent the other way: −3.9 KB raw, +261 B gzip.pass: 2made no difference. This only touches the CDN bundle config, not npm builds.How to review: Single config line. I ran the browser integration tests against
bundle_tracing_replay_min: 641 passed, and 1 failed. That one (web-vitals-cls-without-array-at) also fails ondeveloplocally.🤖 Generated with Claude Code