Repository navigation
chore: Use What/Why structure in PR template - #26348
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreiborza
changed the title
andreiborza
marked this pull request as ready for review
November 13, 2026 09:20
javascript-sdk-gitflow
Bot
requested review from
HazAT,
nicohrubec and
s1gr1d
November 13, 2026 09:20
chargome
approved these changes
Nov 13, 2026
nicohrubec
approved these changes
Nov 13, 2026
s1gr1d
reviewed
Nov 13, 2026
Comment on lines
+4
to
+6
| - [ ] If you've added code that should be tested, please add tests. | ||
| - [ ] Ensure your code lints and the test suite passes (`pnpm run lint`) & (`pnpm run test`). | ||
| - [ ] Link the related issue. External contributors need a maintainer's go-ahead in that issue. |
Member
There was a problem hiding this comment.
the checkboxes make no sense imo, the entries are not something to "tick-off", but more a guidance. This should rather be a list. Why not reuse the commented out part from before?
andreiborza
changed the title
mydea
approved these changes
Nov 13, 2026
s1gr1d
approved these changes
Nov 13, 2026
| - Large PR? Split or stack it, or describe why you cannot. | ||
|
|
||
| - Remove fields that do not apply (e.g. on small PRs). | ||
| - External contributors: link an issue where you got a maintainer's go-ahead. |
Member
There was a problem hiding this comment.
I think we should keep this line somewhere.
Co-authored-by: Sigrid <32902192+s1gr1d@users.noreply.github.com>
JPeer264
approved these changes
Nov 13, 2026
JPeer264
approved these changes
Nov 13, 2026
…evert-pr-template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The PR template now asks for a short What and Why section and an optional linked issue.
Why
Short descriptions that focus on behavior and intent are faster to review than a checklist or many fields.