Repository navigation
chore(bundler-plugins): Type-check tests via lint:types - #26345
Merged
Merged
Conversation
Contributor
size-limit report 📦Compared: 8e338ad (PR test merge using develop at 4f5b3fd) Against: 4f5b3fd (develop) · base run #65980 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 5 not successful, 44 successful. See the run.
Successful checks
|
mydea
marked this pull request as ready for review
November 13, 2026 10:40
javascript-sdk-gitflow
Bot
requested review from
HazAT,
JPeer264 and
chargome
November 13, 2026 10:41
`check:types` was never run in CI, so the test type errors it would have caught went unnoticed. Extend `lint:types` (which CI runs) to cover `test` and drop `check:types`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
chore/bundler-plugins-lint-types-tests
branch
from
November 13, 2026 10:57
6b9ae7c to
b71e0be
Compare
s1gr1d
approved these changes
Nov 13, 2026
mydea
enabled auto-merge (squash)
November 13, 2026 11:02
JPeer264
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
check:typesinbundler-pluginswasn't run anywhere in CI, and the only type step that was (lint:types) coveredsrconly. So the tests had picked up three type errors that nobody noticed. This extendslint:typestotest(oxlint's--type-checkusestest/tsconfig.jsonand reports the same errors astsc), removes the now-redundantcheck:typesscripts, and fixes the errors.How to review: In
component-annotation-oxc.test.ts, the helper now parses with@babel/core'sparseSyncinstead of@babel/parser.@babel/parserv8 produces@babel/typesv8 nodes, which don't type-match the v7traversethey're passed to.🤖 Generated with Claude Code