Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 9454409 (PR test merge using develop at 9279303) Against: 9279303 (develop) · base run #66015 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 1 successful. See the run. Successful checks
|
timfish
force-pushed
the
feat/solidstart-delete-sourcemaps-after-upload
branch
2 times, most recently
from
November 13, 2026 11:34
d4cd675 to
814a202
Compare
Base automatically changed from
feat/bundler-plugins-delete-without-upload
to
develop
November 13, 2026 13:49
…ad of a glob The SDK enables hidden source maps when the app sets none and now passes `deleteSourcemapsAfterUpload: true` and `sdkEnabledSourceMaps` to the bundler plugin for those builds, on SolidStart 1 and 2. This replaces the default `.*/**/*.map` and `./**/*.map` globs. Maps now also go away when no upload runs, and when a user's `assets` or `ignore` leaves chunks out. The SDK only answers for the top-level `build.sourcemap`. Nitro gives its `nitro` and `ssr` environments their own setting, and `@sentry/nitro` uploads and deletes those maps after the build, so they stay with it. The enable plugin moves before the Sentry plugin, because the bundler plugin decides in its own `config` hook. Maps the user enabled keep today's behaviour. With `disable: 'disable-upload'`, SolidStart 1 still removes the maps the SDK turned on, and SolidStart 2 keeps them. A user's own `deleteSourcemapsAfterUpload` passes through to every environment, and a user's own `filesToDeleteAfterUpload` runs as well.
timfish
force-pushed
the
feat/solidstart-delete-sourcemaps-after-upload
branch
from
November 13, 2026 13:53
814a202 to
96468c2
Compare
timfish
marked this pull request as ready for review
November 13, 2026 17:36
javascript-sdk-gitflow
Bot
requested review from
chargome,
nicohrubec and
s1gr1d
November 13, 2026 17:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the app sets no
build.sourcemap, the SolidStart SDK turns on hidden source maps and deleted them with a default glob. The SolidStart 1 glob.*/**/*.mapdeleted every map in any dot folder, not only the ones the SDK created. The SolidStart 2 glob./**/*.mapskipped dot folders, so when no upload ran, for example without an auth token, the client maps stayed in.output/publicand were served. Both SDKs now passdeleteSourcemapsAfterUpload: trueandsdkEnabledSourceMapsto the bundler plugin for builds where the SDK enabled the maps. The plugin then removes all of those maps from the build output: also when no upload runs, and also for chunks that a user'sassetsorignoreleaves out. The SDK only answers for the top-levelbuild.sourcemap. Nitro gives itsnitroandssrenvironments their own setting, and@sentry/nitrostill uploads and deletes those server maps after the build.Maps the user enabled with
build.sourcemapkeep today's behaviour. One change: on SolidStart 2 withbuild.sourcemapunset, maps that an output turns on with its ownrollupOptions.output.sourcemaporrolldownOptions.output.sourcemap(trueor'hidden') are now removed, where they stayed before. Withdisable: 'disable-upload', SolidStart 1 still removes the maps the SDK turned on, and SolidStart 2 keeps them, as before and as@sentry/nitrodoes for the server. A user's ownfilesToDeleteAfterUploadstill runs next to the SDK's deletion.The SDK's enable plugin now runs before the Sentry plugin, because the bundler plugin decides in its own
confighook. Insolidstart-2the client map assertion is now strict. Its chunk recorder moved togenerateBundle, because the plugin removes maps from the bundle beforewriteBundle, which had exempted every debug ID. Both E2E apps get a no-upload variant.