Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 9dc8159 (PR test merge using develop at 9279303) Against: 9279303 (develop) · base run #66015 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsAll optional checks were successful. 2 successful. See the run. |
timfish
force-pushed
the
feat/astro-delete-sourcemaps-after-upload
branch
from
November 13, 2026 11:34
870512f to
0e5b711
Compare
Base automatically changed from
feat/bundler-plugins-delete-without-upload
to
develop
November 13, 2026 13:49
timfish
force-pushed
the
feat/astro-delete-sourcemaps-after-upload
branch
from
November 13, 2026 13:53
0e5b711 to
03a9d1a
Compare
timfish
marked this pull request as ready for review
November 13, 2026 17:36
javascript-sdk-gitflow
Bot
requested review from
chargome,
nicohrubec and
s1gr1d
November 13, 2026 17:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Astro SDK deleted the source maps it turned on with four default
filesToDeleteAfterUploadglobs under./dist, which missed a customoutDir. Now the SDK passesdeleteSourcemapsAfterUploadand the internalsdkEnabledSourceMapsflag to the bundler plugin when it setvite.build.sourcemap: 'hidden'itself. The plugin then removes these maps from the configured client, server and prerender output, also for chunks outside a user's ownassetsorignore, and also when no upload runs. Withdisable: 'disable-upload'the maps are still removed, as the old globs removed them, and the plugin stamps the debug IDs first.The SDK removes every map that the old globs removed, with one exception:
.mapfiles copied frompublic/into the output are not build output, so they now stay. Older Cloudflare adapters (Astro 5) write the Worker todist/_worker.js, which the old globs never matched, so the SDK still keeps those maps for wrangler'supload_source_mapsby answering per Vite build. Maps the user enabled keep today's behaviour, a user's owndeleteSourcemapsAfterUploadis passed through, and a user's ownfilesToDeleteAfterUploadreplaces the SDK's deletion as it does today. Theastro-7-sourcemapsE2E app gets a no-upload variant with a customoutDirthat asserts each environment made maps and that none remain.