Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 7e07b01 (PR test merge using develop at 9279303) Against: 9279303 (develop) · base run #66015 ✅ Baseline matches: this diff contains only this PR's changes.
|
timfish
force-pushed
the
feat/gatsby-delete-sourcemaps-after-upload
branch
from
November 13, 2026 11:34
0e1ebee to
fa0c152
Compare
Base automatically changed from
feat/bundler-plugins-delete-without-upload
to
develop
November 13, 2026 13:49
…f a glob The SDK now passes `deleteSourcemapsAfterUpload` to the webpack plugin instead of the `./public/**/*.map` glob. The user's own option wins, and `true` is the fallback when the SDK turned on hidden source maps. When it is set, the SDK also sets `sdkEnabledSourceMaps`, so the plugin removes all maps of the build, also CSS maps and maps of chunks outside the upload, and also when no upload runs. Both options are only passed in the `build-javascript` stage, because Gatsby reads the `build-html` maps in `.cache` to map HTML render errors.
timfish
force-pushed
the
feat/gatsby-delete-sourcemaps-after-upload
branch
from
November 13, 2026 13:53
fa0c152 to
c91ce96
Compare
timfish
marked this pull request as ready for review
November 13, 2026 17:36
javascript-sdk-gitflow
Bot
requested review from
chargome,
nicohrubec and
s1gr1d
November 13, 2026 17:36
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c91ce96. Configure here.
| plugins: expect.arrayContaining([expect.any(Object)]), | ||
| }), | ||
| ); | ||
|
|
There was a problem hiding this comment.
Feat lacks integration or E2E test
Medium Severity
This was flagged because the review guidelines require feat PRs to include an integration or E2E test. Coverage here is only unit tests that assert plugin options, so they never confirm that a real Gatsby public/ build has neither leftover .map files nor sourceMappingURL comments after deletion.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit c91ce96. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gatsby SDK deleted source maps with a
./public/**/*.mapglob after the upload. It now passesdeleteSourcemapsAfterUploadto the webpack plugin instead. The user's own option wins, andtrueis the fallback when the SDK turned on hidden source maps. When deletion is on, the SDK also sets the internalsdkEnabledSourceMapsflag, so the plugin removes every map the build emits, also CSS maps and maps of chunks the upload leaves out, and also when no upload runs. Both options are only passed in thebuild-javascriptstage. Gatsby reads thebuild-htmlmaps in.cacheto map HTML render errors, and the old glob never touched them either.There are two differences. First, with
devtool: 'source-map'anddeleteSourcemapsAfterUpload: truethe plugin now switches to hidden source maps; before, the glob leftsourceMappingURLcomments that pointed to deleted files. Second, maps that the current build did not emit, such as maps copied fromstatic/or left inpublic/from an earlier build, are no longer removed.There is no Gatsby E2E app, so only unit tests cover this. Note that Gatsby's own production default is
devtool: 'source-map', so the SDK does not turn maps on or delete them in a default Gatsby build. This PR does not change that.