Repository navigation
Conversation
Contributor
size-limit report 📦Compared: 30d4ddb (PR test merge using develop at 9279303) Against: 9279303 (develop) · base run #66015 ✅ Baseline matches: this diff contains only this PR's changes.
|
timfish
force-pushed
the
feat/remix-delete-sourcemaps-after-upload
branch
from
November 13, 2026 11:34
63b2997 to
dec1d10
Compare
Base automatically changed from
feat/bundler-plugins-delete-without-upload
to
develop
November 13, 2026 13:49
timfish
force-pushed
the
feat/remix-delete-sourcemaps-after-upload
branch
from
November 13, 2026 13:53
dec1d10 to
5eab8cf
Compare
timfish
marked this pull request as ready for review
November 13, 2026 17:36
javascript-sdk-gitflow
Bot
requested review from
chargome,
nicohrubec and
s1gr1d
November 13, 2026 17:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the app set no
build.sourcemap, the Remix SDK turned on hidden source maps and then deleted them with an<outDir>/**/*.mapglob for the client and the server build. It now passesdeleteSourcemapsAfterUpload: trueand the internalsdkEnabledSourceMapsflag to the bundler plugin for those builds. The plugin then removes the maps before Vite writes them, also when no upload runs. The SDK only knows that it turned maps on in its ownconfighook, after it created the bundler plugin, so it passes both options as functions, and its enable plugin now runs before the bundler plugin'sconfighook.Maps the user turned on stay, as before. With
disable: 'disable-upload'the maps also stay, so the user can upload them by hand. A user's ownfilesToDeleteAfterUploadis passed through and runs as well, as before. One difference: the old glob deleted every.mapfile in the output directory, but the plugin removes only maps the build emitted, so.mapfiles copied frompublic/now stay. Theremix-sourcemapsE2E app gets a no-upload variant that asserts no maps and nosourceMappingURLcomments inbuild. This depends on #26281.