Repository navigation
feat(server-utils): Record Bedrock prompts, system instructions, and tool definitions - #26249
Merged
Merged
Conversation
…d tool definitions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreiborza
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit faabebf. Configure here.
Contributor
size-limit report 📦Compared: 502792e (PR test merge using develop at 3e2f711) Against: 3e2f711 (develop) · base run #65851 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
|
One or more gzipped bundles increased by more than 500 bytes. If this increase is intentional, add the Accept Bundlesize Increase label to this PR to rerun and accept the check. |
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 54 successful. See the run.
Successful checks
|
…b/bedrock-gen-ai-inputs
…b/bedrock-gen-ai-inputs
…inputs # Conflicts: # packages/server-utils/src/integrations/aws-sdk/services/bedrock-runtime.ts
andreiborza
marked this pull request as ready for review
November 13, 2026 13:06
andreiborza
requested review from
chargome and
nicohrubec
and removed request for
Lms24 and
isaacs
November 13, 2026 13:06
chargome
approved these changes
Nov 13, 2026
| * Claude `InvokeModel` bodies are Anthropic Messages API requests, so they are recorded like the Anthropic | ||
| * integration records them. | ||
| */ | ||
| export function getClaudeInputAttributes(body: Record<string, unknown>): Record<string, unknown> { |
Member
There was a problem hiding this comment.
Does this one handle inline media? So we don't attach raw base64 to gen_ai.input.messages?
Member
Author
There was a problem hiding this comment.
No, it doesn't, which is in line with the anthropic integration. A while ago we decided to walk back on truncation and stripping images out. This has since changed, but we need to align this on all integrations.
Webby and I are working on aligning integrations more in the future, but we are at the stage of writing clearer specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bedrock
Converse,ConverseStream,InvokeModel, andInvokeModelWithResponseStreamspans now record the input messages, system instructions, and tool definitions. Claude request bodies are recorded like the Anthropic integration records them, anddataCollection.genAI.inputsturns this off.Extracted from #26118.
Why
Other AI integrations already record their inputs, so Bedrock spans showed less in the AI views.