Repository navigation
test(e2e): Run OTel SDK E2E apps on SDK v3 with an SDK v2 variant - #25703
Draft
andreiborza wants to merge 6 commits into
Draft
andreiborza wants to merge 6 commits into
andreiborza wants to merge 6 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
…ault # Conflicts: # dev-packages/e2e-tests/test-applications/node-express-otlp/package.json # dev-packages/e2e-tests/test-applications/node-otel-sdk-node-v3/package.json # dev-packages/e2e-tests/test-applications/node-otel-sdk-node/package.json # dev-packages/e2e-tests/test-applications/sveltekit-2-otlp/package.json # packages/cloudflare/package.json # packages/deno/package.json # packages/hono/package.json # packages/node/package.json # packages/opentelemetry/package.json # packages/react-router/package.json # packages/server-utils/package.json # packages/sveltekit/package.json # packages/tanstackstart-react/package.json # packages/vercel-edge/package.json
Contributor
size-limit report 📦Compared: bd08ea3 (PR test merge using develop at 6a4315b) Against: 6a4315b (develop) · base run #66045 ✅ Baseline matches: this diff contains only this PR's changes.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6eaa55c. Configure here.
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 4 not successful, 56 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The OpenTelemetry SDK E2E apps now run on OTel SDK v3 by default, and each has an OTel SDK v2 variant.
node-otel-sdk-node,node-express-otlp,nextjs-otlpandsveltekit-2-otlpuse SDK v3, with a v2 variant on@opentelemetry/api1.9.1node-otel-sdk-node-v3, which the default run now coversWhy
Users run both SDK major versions, and they need different
@opentelemetry/apiminors. The tests are the same, so only the setup changes per variant.