chore(repo): Add low cardinality span name setting skill - #23449
Draft
Lms24 wants to merge 1 commit into
Draft
Conversation
Contributor
size-limit report 📦
|
RulaKhaled
reviewed
Aug 18, 2026
RulaKhaled
left a comment
RulaKhaled
left a comment
Collaborator
There was a problem hiding this comment.
Looks solid. Left a question on the fallback examples (same static-route case as #23424) and a note on streamed e2e attribute assertions.
|
|
||
| ```ts | ||
| // With span streaming, span names have to be low cardinality, so we can't fall back to the URL. | ||
| name: parameterizedRoute ?? (hasSpanStreamingEnabled(client) ? NAVIGATION_SPAN_NAME_FALLBACK : pathname), |
Collaborator
There was a problem hiding this comment.
I guess same question as on #23424, we can align on that before changing this.
|
|
||
| The scope is only a valid fallback for standalone spans, which are sent without their segment span. `packages/browser-utils/src/web-vitals/spans.ts` is the worked example. | ||
|
|
||
| ## 7. Verify |
Collaborator
There was a problem hiding this comment.
Could we note that toMatchObject against a plain string / url.pathname will fail for streamed e2e attributes here so the next op doesn’t copy #23424’s assertions? 👀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.