Skip to content

Portable http.Server integration #20779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacs wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Portable http.Server integration #20779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ffb2f0
feat(core, node): portable Connect integration
isaacs May 9, 2026
8514248
feat(core): HTTP server-spans subscription utility
isaacs May 9, 2026
8134669
feat(node-core): use core HTTP server subscription utility in light SDK
isaacs May 9, 2026
c72f522
fix(node-core): use core HTTP server subscription utility in httpServ…
isaacs May 9, 2026
2954cdc
chore(node-core): drop unused captureRequestBody
isaacs May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/node-connect/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
},
{
data: {
'sentry.origin': 'auto.http.otel.connect',
'sentry.origin': 'auto.http.connect',
'sentry.op': 'request_handler.connect',
'http.route': '/test-transaction',
'connect.type': 'request_handler',
Expand All @@ -86,7 +86,7 @@ test('Sends an API route transaction', async ({ baseURL }) => {
status: 'ok',
timestamp: expect.any(Number),
trace_id: expect.stringMatching(/[a-f0-9]{32}/),
origin: 'auto.http.otel.connect',
origin: 'auto.http.connect',
},
],
transaction: 'GET /test-transaction',
Expand Down
50 changes: 22 additions & 28 deletions dev-packages/node-integration-tests/suites/tracing/connect/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ describe('connect auto-instrumentation', () => {
'connect.name': '/',
'connect.type': 'request_handler',
'http.route': '/',
'sentry.origin': 'auto.http.otel.connect',
'sentry.origin': 'auto.http.connect',
'sentry.op': 'request_handler.connect',
}),
description: '/',
origin: 'auto.http.otel.connect',
origin: 'auto.http.connect',
op: 'request_handler.connect',
status: 'ok',
}),
Expand All @@ -36,32 +36,26 @@ describe('connect auto-instrumentation', () => {
},
};

createEsmAndCjsTests(
__dirname,
'scenario.mjs',
'instrument.mjs',
(createTestRunner, test) => {
test('should auto-instrument `connect` package.', async () => {
const runner = createTestRunner().expect({ transaction: EXPECTED_TRANSACTION }).start();
runner.makeRequest('get', '/');
await runner.completed();
});
createEsmAndCjsTests(__dirname, 'scenario.mjs', 'instrument.mjs', (createTestRunner, test) => {
test('should auto-instrument `connect` package.', async () => {
const runner = createTestRunner().expect({ transaction: EXPECTED_TRANSACTION }).start();
runner.makeRequest('get', '/');
await runner.completed();
});

test('should capture errors in `connect` middleware.', async () => {
const runner = createTestRunner().ignore('transaction').expect({ event: EXPECTED_EVENT }).start();
runner.makeRequest('get', '/error');
await runner.completed();
});
test('should capture errors in `connect` middleware.', async () => {
const runner = createTestRunner().ignore('transaction').expect({ event: EXPECTED_EVENT }).start();
runner.makeRequest('get', '/error');
await runner.completed();
});

test('should report errored transactions.', async () => {
const runner = createTestRunner()
.ignore('event')
.expect({ transaction: { transaction: 'GET /error' } })
.start();
runner.makeRequest('get', '/error');
await runner.completed();
});
},
{ failsOnEsm: true },
);
test('should report errored transactions.', async () => {
const runner = createTestRunner()
.ignore('event')
.expect({ transaction: { transaction: 'GET /error' } })
.start();
runner.makeRequest('get', '/error');
await runner.completed();
});
});
});
5 changes: 5 additions & 0 deletions packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@ export type {
ExpressMiddleware,
ExpressErrorMiddleware,
} from './integrations/express/types';
export { patchConnectModule, setupConnectErrorHandler } from './integrations/connect/index';
export type { ConnectIntegrationOptions, ConnectModule } from './integrations/connect/index';
export { dedupeIntegration } from './integrations/dedupe';
export { extraErrorDataIntegration } from './integrations/extraerrordata';
export { rewriteFramesIntegration } from './integrations/rewriteframes';
Expand All @@ -152,6 +154,9 @@ export { growthbookIntegration } from './integrations/featureFlags';
export { conversationIdIntegration } from './integrations/conversationId';
export { patchHttpModuleClient } from './integrations/http/client-patch';
export { getHttpClientSubscriptions } from './integrations/http/client-subscriptions';
export { getHttpServerSubscriptions } from './integrations/http/server-subscription';
export { recordRequestSession } from './integrations/http/record-request-session';
export { getHttpServerSpanSubscriptions, isStaticAssetRequest } from './integrations/http/server-span-subscription';
export { addOutgoingRequestBreadcrumb } from './integrations/http/add-outgoing-request-breadcrumb';
export {
getRequestUrl,
Expand Down
Loading
Loading