Skip to content

fix: improve http.client double-wrap message #20705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacs wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: improve http.client double-wrap message #20705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/core/src/integrations/http/double-wrap-warning.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ const isOtelWrapped = (fn: Function & { __unwrap?: Function }): fn is Function &

// exported for tess
export const warning =
'Double-wrapped http.client detected. Either disable spans in Sentry.httpIntegration, or disable the OpenTelemetry HTTP instrumentation.';
'Double-wrapped http.client detected. Either disable spans in Sentry.httpIntegration, or disable the OpenTelemetry HTTP instrumentation. See: https://docs.sentry.io/platforms/javascript/guides/express/opentelemetry/custom-setup/#custom-http-instrumentation';
Comment thread
isaacs marked this conversation as resolved.

let didDoubleWrapWarning = false;
// no-op in non-debug builds
export const doubleWrapWarning = DEBUG_BUILD
? (http: HttpModuleExport) => {
if (!didDoubleWrapWarning) {
if (isOtelWrapped(http.request) || isOtelWrapped(http.get)) {
// TODO: add link to documentation
didDoubleWrapWarning = true;
debug.warn(warning);
}
Expand Down
Loading