chore: Clean up lint and format script names#19719
Open
Conversation
Standardize script naming across the monorepo: - `lint` → oxlint only (was oxlint + oxfmt) - `lint:fix` → oxlint --fix (was `fix`) - `format` → oxfmt --write (unchanged) - `format:check` → oxfmt --check (unchanged) - `check` → runs both format:check + lint (new, root only) All oxlint commands now consistently include the OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS flag and --type-aware across root and all sub-packages. Removes redundant scripts: fix, fix:oxlint, fix:oxfmt, lint:oxfmt, lint:oxlint. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: Ember
lint:jsnot updated with new flags- Updated lint:js script to include OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true and --type-aware flags for consistency with other packages.
- ✅ Fixed: Deno orphaned
prefixhook afterfixremoval- Renamed the orphaned prefix hook to prelint:fix to properly run deno-types before the lint:fix script.
Or push these changes by commenting:
@cursor push fefd10c5dd
Preview (fefd10c5dd)
diff --git a/packages/deno/package.json b/packages/deno/package.json
--- a/packages/deno/package.json
+++ b/packages/deno/package.json
@@ -36,7 +36,7 @@
"build:tarball": "npm pack",
"circularDepCheck": "madge --circular src/index.ts",
"clean": "rimraf build build-types build-test coverage node_modules/.deno sentry-deno-*.tgz",
- "prefix": "yarn deno-types",
+ "prelint:fix": "yarn deno-types",
"lint:fix": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . --fix --type-aware",
"prelint": "yarn deno-types",
"lint": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . --type-aware",
diff --git a/packages/ember/package.json b/packages/ember/package.json
--- a/packages/ember/package.json
+++ b/packages/ember/package.json
@@ -21,7 +21,7 @@
"clean": "yarn rimraf sentry-ember-*.tgz dist tmp build .node_modules.ember-try package.json.ember-try instance-initializers index.d.ts runloop.d.ts types.d.ts",
"lint": "run-p lint:js lint:hbs lint:ts",
"lint:hbs": "ember-template-lint .",
- "lint:js": "oxlint .",
+ "lint:js": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . --type-aware",
"lint:ts": "tsc",
"lint:fix": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . --fix --type-aware",
"start": "ember serve",| "clean": "rimraf build build-types build-test coverage node_modules/.deno sentry-deno-*.tgz", | ||
| "prefix": "yarn deno-types", | ||
| "fix": "oxlint . --fix", | ||
| "lint:fix": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . --fix --type-aware", |
There was a problem hiding this comment.
Deno orphaned prefix hook after fix removal
Medium Severity
The prefix lifecycle hook (which runs yarn deno-types before the old fix script) is now orphaned since fix was removed and replaced by lint:fix. Running yarn lint:fix in the deno package won't trigger prefix, so deno types won't be downloaded first. The hook needs to be renamed to prelint:fix to match the new script name.
Additional Locations (1)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Standardizes lint/format script naming across the monorepo, separating formatting checks from linting and aligning oxlint invocation flags, and updates CI to use the new script names.
Changes:
- Renames
fix→lint:fixand simplifieslintto run only oxlint (with consistent env flag +--type-aware) across packages. - Adds a root
checkscript to runformat:check+lint. - Updates CI workflow to call
yarn lintinstead of the removedyarn lint:oxlint, and updates contributor docs accordingly.
Reviewed changes
Copilot reviewed 53 out of 53 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Reworks root lint/fix scripts; adds check; keeps format/format:check. |
| .github/workflows/build.yml | Updates lint step to run yarn lint. |
| AGENTS.md | Updates documented yarn commands to reflect new lint/format scripts. |
| dev-packages/test-utils/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/size-limit-gh-action/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/node-overhead-gh-action/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/node-integration-tests/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/node-core-integration-tests/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/external-contributor-gh-action/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/e2e-tests/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/cloudflare-integration-tests/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/clear-cache-gh-action/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| dev-packages/browser-integration-tests/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/angular/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/astro/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/aws-serverless/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/browser-utils/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/browser/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/bun/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/cloudflare/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/core/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/deno/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/ember/package.json | Updates fix script naming; partially standardizes oxlint flags. |
| packages/eslint-plugin-sdk/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/feedback/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/gatsby/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/google-cloud-serverless/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/hono/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/integration-shims/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/nestjs/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/nextjs/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/node-core/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/node-native/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/node/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/nuxt/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/opentelemetry/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/profiling-node/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/react-router/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/react/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/remix/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/replay-canvas/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/replay-internal/package.json | Splits out format/format:check; standardizes oxlint flags; removes composite fix/lint scripts. |
| packages/replay-worker/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/solidstart/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/solid/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/sveltekit/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/svelte/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/tanstackstart-react/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/tanstackstart/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/types/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/vercel-edge/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/vue/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
| packages/wasm/package.json | Renames fix→lint:fix and standardizes oxlint flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+23
to
+26
| | `yarn lint` | Lint (Oxlint) | | ||
| | `yarn lint:fix` | Lint + auto-fix (Oxlint) | | ||
| | `yarn format` | Format files (Oxfmt) | | ||
| | `yarn format:check` | Check formatting (Oxfmt) | |
There was a problem hiding this comment.
This doc updates the lint/format commands, but it doesn’t mention the newly added root-only yarn check script (format check + lint) described in the PR. Add yarn check to the command table so contributors can discover and use the new workflow.
Comment on lines
22
to
+26
| "lint": "run-p lint:js lint:hbs lint:ts", | ||
| "lint:hbs": "ember-template-lint .", | ||
| "lint:js": "oxlint .", | ||
| "lint:ts": "tsc", | ||
| "fix": "oxlint . --fix", | ||
| "lint:fix": "OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS=true oxlint . --fix --type-aware", |
There was a problem hiding this comment.
yarn lint in this package runs lint:js, but lint:js still uses oxlint . without the OXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICS flag and without --type-aware, while lint:fix does include both. This makes lint and lint:fix inconsistent and also contradicts the PR’s goal of standardizing oxlint invocations. Update lint:js (and any other oxlint scripts here) to use the same flags as lint:fix (or alternatively make lint directly invoke the standardized oxlint command).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize lint/format script naming across the monorepo (53 files). Removes redundant/confusing scripts and makes naming consistent.
New root-level scripts
verifyrun-s format:check lintfixrun-s format lint:fixlintoxlint . --type-awarelint:fixoxlint . --fix --type-awareformatoxfmt . --writeformat:checkoxfmt . --checkWhat changed
lintnow runs only oxlint (previously also ran oxfmt check)lint:fixreplaces oldfixfor oxlint auto-fixverifyruns bothformat:check+lint(replaces oldlintbehavior)fixruns bothformat+lint:fixOXLINT_TSGOLINT_DANGEROUSLY_SUPPRESS_PROGRAM_DIAGNOSTICSflag and--type-awareacross root and all sub-packagesfix:oxlint,fix:oxfmt,lint:oxfmt,lint:oxlintbuild.yml) to use new script namesTest plan
yarn lintinstead ofyarn lint:oxlintyarn format:check)yarn verifyruns both format check and lint at root levelyarn fixruns both format and lint fix at root level🤖 Generated with Claude Code
Closes #19722 (added automatically)