Conversation
Contributor
size-limit report 📦
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
…ooglebot-rendering-failures
… prevent CI timeout The first dynamic import after vi.resetModules() needs to compile the entire SDK module graph from scratch, which can hang on slower CI runners. Pre-importing the modules in beforeAll warms the V8 compilation cache. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chargome
commented
Mar 9, 2026
Comment on lines
+23
to
+31
| beforeAll(async () => { | ||
| // Pre-warm V8 compilation cache for the large SDK module graphs. | ||
| // Without this, the first dynamic import after vi.resetModules() can hang | ||
| // because vitest needs to compile the entire module graph from scratch. | ||
| await import('../../src/client/index.js'); | ||
| await import('../../src/server/index.js'); | ||
| await import('../../src/edge/index.js'); | ||
| vi.resetModules(); | ||
|
|
Member
Author
There was a problem hiding this comment.
unrelated but these tests are flaky on node 20 and this fixes it
Lms24
approved these changes
Mar 9, 2026
Member
There was a problem hiding this comment.
LGTM! For future reference, Relay has an extensive list of web crawlers (including some they explicitly allow). Adding all of these here would be bundle size overkill IMO, so this subset seems fine as it seems to cover the most important ones.
…ooglebot-rendering-failures
chargome
deleted the
cg/JS-1873/sentry-browsertracing-causes-googlebot-rendering-failures
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #19670
When browserTracingIntegration initializes, it creates a 30-second setTimeout (idle span final timeout), multiple PerformanceObserver instances, and various other timers. These keep the JS event loop active, which prevents Googlebot's headless Chromium renderer from considering the page "idle" — resulting in incomplete or broken page snapshots in Google Search Console.
This PR detects known bot/crawler user agents and skips the tracing setup entirely, so no timers or observers are created. Error monitoring via other integrations is unaffected.