Skip to content

test(angular): Fix failing canary test #19639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 8 commits into from
Mar 9, 2026
+3 −12
Merged

test(angular): Fix failing canary test #19639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8d9f4c5
test(angular): Fix failing canary test
Lms24 Mar 5, 2026
bf61772
tmp change angular package.json to run test app
Lms24 Mar 5, 2026
42dd371
force install?
Lms24 Mar 5, 2026
37ef6f5
more force
Lms24 Mar 5, 2026
dcfeac7
bump to node 22 for angular-21 (?)
Lms24 Mar 9, 2026
c5da162
remove angular 20 canary test (in favour of ng21)
Lms24 Mar 9, 2026
cac1432
remove --force
Lms24 Mar 9, 2026
53f6bea
Reset angular package change
Lms24 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ jobs:
fail-fast: false
matrix:
include:
- test-application: 'angular-20'
- test-application: 'angular-21'
build-command: 'test:build-canary'
label: 'angular-20 (next)'
label: 'angular-21 (next)'
- test-application: 'create-react-app'
build-command: 'test:build-canary'
label: 'create-react-app (canary)'
Expand Down Expand Up @@ -130,7 +130,6 @@ jobs:
with:
version: 9.15.9
- name: Set up Node
if: matrix.test-application != 'angular-20'
Copy link
Member Author

@Lms24 Lms24 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turns out this was no longer necessary at all. Now we just set Node 22 in the angular-21 package.json.

uses: actions/setup-node@v6
with:
node-version-file: 'dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}/package.json'
Expand Down
9 changes: 0 additions & 9 deletions dev-packages/e2e-tests/test-applications/angular-20/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"watch": "ng build --watch --configuration development",
"test": "playwright test",
"test:build": "pnpm install && pnpm build",
"test:build-canary": "pnpm install && pnpm add @angular/animations@next @angular/common@next @angular/compiler@next @angular/core@next @angular/forms@next @angular/platform-browser@next @angular/platform-browser-dynamic@next @angular/router@next && pnpm add -D @angular-devkit/build-angular@next @angular/cli@next @angular/compiler-cli@next && pnpm build",
"test:assert": "playwright test",
"clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
},
Expand Down Expand Up @@ -48,13 +47,5 @@
},
"volta": {
"extends": "../../package.json"
},
"sentryTest": {
"optionalVariants": [
{
"build-command": "pnpm test:build-canary",
"label": "angular (canary)"
}
]
}
}
1 change: 1 addition & 0 deletions dev-packages/e2e-tests/test-applications/angular-21/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"typescript": "~5.9.0"
},
"volta": {
"node": "22.22.0",
"extends": "../../package.json"
},
"sentryTest": {
Expand Down
Loading