feat(ember)!: Update to v2 addon format #19229
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import type ApplicationInstance from '@ember/application/instance'; | ||
| import { addIntegration, browserTracingIntegration } from '@sentry/ember'; | ||
|
|
||
| export function initialize(appInstance: ApplicationInstance): void { | ||
|
Member
There was a problem hiding this comment. Hey, I am taking another look over this as we are getting closer to planning the next major, where this could go in. Ideally, we'd align this more closely with how we handle sentry init in other places as well - which would be, to keep things centralized in // app.ts
export default class App extends Application {
modulePrefix = config.modulePrefix;
podModulePrefix = config.podModulePrefix;
Resolver = Resolver;
}
Sentry.init({
// ...
integrations: [
Sentry.browserTracingIntegration({ emberApp: App })
]
});and somehow derive/wrap the necessary thing inside of this? That would be the ideal solution IMHO, or something along these lines. then we can also get rid of all the async import and special options for performance etc. and just pass this directly to the (ember-specific) browser tracing integration 🤔
Member
There was a problem hiding this comment. Or alternatively, if this cannot be made to work nicely, we could also do this in the initializer, which would be more "sentry native": import * as Sentry from '@sentry/ember';
export function initialize(appInstance) {
Sentry.addIntegration(Sentry.browserTracingIntegration({
appInstance,
// other options here
});
}this would possibly loose tiny bits of timing info but should overall be likely OK... Then, we need to export a custom
Member
There was a problem hiding this comment. I will look into PRing into this PR some changes for this! |
||
| addIntegration(browserTracingIntegration({ | ||
| appInstance, | ||
| minimumRunloopQueueDuration: 0, | ||
| minimumComponentRenderDuration: 0, | ||
| })); | ||
| } | ||
|
aklkv marked this conversation as resolved.
|
||
|
|
||
| export default { | ||
| initialize, | ||
| }; | ||
Uh oh!
There was an error while loading. Please reload this page.