Add logger bundle variants

[behnammodi]

Adds 7 new logger bundle variants to @sentry/browser that combine the logger integration with various other features (tracing, replay, feedback).

Bundles Added

• bundle.logger
• bundle.tracing.logger
• bundle.replay.logger
• bundle.feedback.logger
• bundle.tracing.replay.logger
• bundle.replay.feedback.logger
• bundle.tracing.replay.feedback.logger

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
• Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #issue_link_here

[sentry]

Bug: The index.bundle.tracing.replay.feedback.logger.ts file imports the shim but fails to export feedbackIntegration, preventing users of this bundle from initializing the feedback feature.
_{Severity: CRITICAL}

🔍 Detailed Analysis

The bundle file index.bundle.tracing.replay.feedback.logger.ts is intended to provide full feedback functionality, as indicated by its name. However, while it exports helper functions like getFeedback and sendFeedback, it incorrectly imports feedbackIntegrationShim and fails to export the main feedbackIntegration or feedbackAsyncIntegration. Consequently, users attempting to initialize Sentry with Sentry.feedbackIntegration() in this bundle will encounter a runtime error because the function will be undefined, making the feedback feature unusable.

💡 Suggested Fix

In index.bundle.tracing.replay.feedback.logger.ts, replace the import of feedbackIntegrationShim with feedbackAsyncIntegration from ./feedbackAsync. Then, add an export statement like export { feedbackAsyncIntegration as feedbackAsyncIntegration, feedbackAsyncIntegration as feedbackIntegration } to correctly expose the integration.

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/browser/src/index.bundle.tracing.replay.feedback.logger.ts#L2

Potential issue: The bundle file `index.bundle.tracing.replay.feedback.logger.ts` is
intended to provide full feedback functionality, as indicated by its name. However,
while it exports helper functions like `getFeedback` and `sendFeedback`, it incorrectly
imports `feedbackIntegrationShim` and fails to export the main `feedbackIntegration` or
`feedbackAsyncIntegration`. Consequently, users attempting to initialize Sentry with
`Sentry.feedbackIntegration()` in this bundle will encounter a runtime error because the
function will be undefined, making the feedback feature unusable.

_{Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 8475823}

[cursor]

Missing feedback integration exports in tracing.replay.feedback.logger bundle

High Severity

The bundle.tracing.replay.feedback.logger bundle is missing the feedback integration exports. It imports feedbackIntegrationShim but never uses it, and it doesn't import feedbackAsyncIntegration from ./feedbackAsync or export feedbackAsyncIntegration/feedbackIntegration. Comparing with index.bundle.tracing.replay.feedback.ts, this file needs to import feedbackAsyncIntegration and export it as both feedbackAsyncIntegration and feedbackIntegration. Without this, users of this bundle won't have access to the feedback integration despite the bundle name suggesting otherwise.

 

[cursor]

Missing integration or E2E tests for new feature

Low Severity · BugBot Rules

Per the rules file in the user instructions: "When reviewing a feat PR, check if the PR includes at least one integration or E2E test. If neither of the two are present, add a comment, recommending to add one." This PR adds 7 new logger bundle variants but doesn't include any integration or E2E tests to verify the bundles work correctly and export the expected APIs. Adding tests would help catch issues like the missing feedback integration exports in the tracing.replay.feedback.logger bundle.

 

[chargome]

Hey @behnammodi, first of all thanks for contributing! We're currently working on this internally to accommodate also for metrics + keep the permutations to a minimum. Due to this I will have to close your pr, sorry for the inconvenience!