Skip to content

ref(react-router): Deprecate ErrorBoundary exports #18208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

ref(react-router): Deprecate ErrorBoundary exports #18208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions packages/react-router/src/client/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@ export * from '@sentry/browser';
export { init } from './sdk';
export { reactRouterTracingIntegration } from './tracingIntegration';

export {
captureReactException,
reactErrorHandler,
Profiler,
withProfiler,
useProfiler,
ErrorBoundary,
withErrorBoundary,
} from '@sentry/react';
export { captureReactException, reactErrorHandler, Profiler, withProfiler, useProfiler } from '@sentry/react';

/**
* @deprecated ErrorBoundary is deprecated, use react router's error boundary instead.
Copy link
Member

@s1gr1d s1gr1d Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated ErrorBoundary is deprecated, use react router's error boundary instead.
* @deprecated ErrorBoundary is deprecated, use React Router's error boundary instead.

Looks a bit more professional if we use the official name in the public exports (same as below)

Copy link
Member Author

@andreiborza andreiborza Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will ammend

* See https://docs.sentry.io/platforms/javascript/guides/react-router/#report-errors-from-error-boundaries
*/
export { ErrorBoundary, withErrorBoundary } from '@sentry/react';

/**
* @deprecated ErrorBoundaryProps and FallbackRender are deprecated, use react router's error boundary instead.
* See https://docs.sentry.io/platforms/javascript/guides/react-router/#report-errors-from-error-boundaries
*/
Copy link

@cursor cursor bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Deprecation Paradox: API Surface Expansion (Bugbot Rules)

This change introduces new public API exports for ErrorBoundaryProps and FallbackRender types that were not previously exported from this package. While marked as deprecated, adding new exports contradicts the PR's intention to deprecate ErrorBoundary functionality. If these types weren't needed before, exporting them now (even as deprecated) expands the public API surface unnecessarily.

Fix in Cursor Fix in Web

Copy link
Member Author

@andreiborza andreiborza Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were exported before...

export type { ErrorBoundaryProps, FallbackRender } from '@sentry/react';
Loading