build(android): Bump AGP to 9.5.1

.github/workflows/agp-matrix.yml

@@ -17,15 +17,15 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        agp: [ '9.0.0', '9.2.1', '9.4.0' ]
+        agp: [ '9.0.0', '9.4.0', '9.5.1' ]
         integrations: [ true, false ]
 
     name: AGP Matrix Release - AGP ${{ matrix.agp }} - Integrations ${{ matrix.integrations }}
     env:
       VERSION_AGP: ${{ matrix.agp }}
       APPLY_SENTRY_INTEGRATIONS: ${{ matrix.integrations }}
       # Upload replay snapshots from one cell only. Forks don't have access to the upload secret.
-      UPLOAD_REPLAY_SNAPSHOTS: ${{ matrix.agp == '9.4.0' && matrix.integrations && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) }}
+      UPLOAD_REPLAY_SNAPSHOTS: ${{ matrix.agp == '9.5.1' && matrix.integrations && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) }}
 
     steps:
       - name: Checkout Repo

gradle/libs.versions.toml

@@ -41,7 +41,7 @@ room2 = "2.8.4"
 room3 = "3.0.0-rc01"
 sagp = "6.13.0"
 # The AGP matrix job overrides this with the VERSION_AGP env var, through each build's settings.
-agp = "9.4.0"
+agp = "9.5.1"
 sqlite = "2.6.2"
 sqliteRc = "2.8.0-alpha03" # Required by Room3 3.0.0-rc*
 slf4j = "1.7.30"

sentry-android-core/src/main/java/io/sentry/android/core/internal/util/ScreenshotUtils.java

@@ -38,7 +38,10 @@ public final class ScreenshotUtils {
   }
 
   // Used by Hybrid SDKs
-  @SuppressLint("NewApi")
+  // Lint infers a UI-thread constraint from the View calls in captureScreenshot, which clashes with
+  // Bitmap.compress's @WorkerThread. captureScreenshot is safe from any thread, as it posts the
+  // view draw to the UI thread when it isn't already on it.
+  @SuppressLint({"NewApi", "ThreadConstraint"})
   public static @Nullable byte[] takeScreenshot(
       final @NotNull Activity activity,
       final @NotNull IThreadChecker threadChecker,

sentry-android-fragment/build.gradle.kts

@@ -54,6 +54,10 @@ android {
 
     // We run a full lint analysis as build part in CI, so skip vital checks for assemble tasks.
     checkReleaseBuilds = false
+
+    // Lint 9.5 can't load the custom checks bundled with older androidx.lifecycle releases and
+    // reports that it skips them. They only cover lifecycle APIs this module doesn't call.
+    disable += "ObsoleteLintCustomCheck"
   }
 
   buildFeatures { buildConfig = true }

sentry-android-integration-tests/sentry-uitest-android/build.gradle.kts

@@ -77,6 +77,10 @@ android {
     // This module is the one lint picks to check the build root's Gradle wrapper, and this check
     // compares it with the latest Gradle release online, so every new release would fail the build.
     disable += "AndroidGradlePluginVersion"
+
+    // Lint 9.5 can't load the custom checks bundled with older androidx.lifecycle releases and
+    // reports that it skips them. They only cover lifecycle APIs this module doesn't call.
+    disable += "ObsoleteLintCustomCheck"
   }
 
   androidComponents.beforeVariants {

sentry-android-navigation/build.gradle.kts

@@ -54,6 +54,10 @@ android {
 
     // We run a full lint analysis as build part in CI, so skip vital checks for assemble tasks.
     checkReleaseBuilds = false
+
+    // Lint 9.5 can't load the custom checks bundled with older androidx.lifecycle releases and
+    // reports that it skips them. They only cover lifecycle APIs this module doesn't call.
+    disable += "ObsoleteLintCustomCheck"
   }
 
   buildFeatures { buildConfig = true }

sentry-android-replay/build.gradle.kts

@@ -62,6 +62,10 @@ android {
 
     // We run a full lint analysis as build part in CI, so skip vital checks for assemble tasks.
     checkReleaseBuilds = false
+
+    // Lint 9.5 can't load the custom checks bundled with older androidx.lifecycle releases and
+    // reports that it skips them. They only cover lifecycle APIs this module doesn't call.
+    disable += "ObsoleteLintCustomCheck"
   }
 
   buildFeatures { buildConfig = true }

sentry-compose/build.gradle.kts

@@ -116,6 +116,10 @@ android {
 
     // We run a full lint analysis as build part in CI, so skip vital checks for assemble tasks.
     checkReleaseBuilds = false
+
+    // Lint 9.5 can't load the custom checks bundled with older androidx.lifecycle releases and
+    // reports that it skips them. They only cover lifecycle APIs this module doesn't call.
+    disable += "ObsoleteLintCustomCheck"
   }
 
   buildFeatures { buildConfig = true }