Repository navigation
docs(android): Fix Javadoc that Error Prone flags in sentry-android-core - #6498
Merged
Merged
Conversation
4 of 9 tasks
Contributor
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
📲 Install BuildsAndroid
|
runningcode
marked this pull request as ready for review
November 10, 2026 08:13
runningcode
requested review from
0xadam-brown and
markushi
and removed request for
a team
November 10, 2026 08:13
runningcode
force-pushed
the
no/android-core-javadoc
branch
from
November 10, 2026 08:24
b126005 to
7b17435
Compare
Error Prone never ran on sentry-android-core. Enabling it reports 34 Javadoc warnings, which fail the build under -Werror: - MissingSummary: turn the @return text into a "Returns ..." summary, and add summaries to Javadocs that only had block tags. - InvalidBlockTag: replace the @noinspection unused Javadoc tags with @SuppressWarnings("unused"), which IntelliJ honors too. - NotJavadoc: turn the Javadoc on methods of an anonymous class into regular comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
runningcode
force-pushed
the
no/android-core-javadoc
branch
from
November 10, 2026 08:41
7b17435 to
75e1184
Compare
romtsn
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes the 34 Javadoc warnings Error Prone reports in
sentry-android-core:MissingSummary: turns the@returntext into a "Returns ..." summary, and adds summaries to Javadocs that only had block tags.InvalidBlockTag: replaces the@noinspection unusedJavadoc tags with@SuppressWarnings("unused"), which IntelliJ honors too.NotJavadoc: turns the Javadoc on methods of an anonymous class into regular comments.💡 Motivation and Context
Error Prone never ran on
sentry-android-core(#6493). Under-Werrorthese warnings fail the build once it does. This is one of four independent PRs that fix what it reports. It targetsmainbecause it changes no behavior or API; it reaches9.x.xwith the next merge frommain.💚 How did you test it?
Compiled with Error Prone enabled: none of these warnings remain and none are added.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Issues
🤖 Generated with Claude Code
#skip-changelog