Skip to content

feat: move tracing to rely on ctx - #1379

Open
giortzisg wants to merge 1 commit into
scopes/context-capturefrom
scopes/context-tracing
Open

feat: move tracing to rely on ctx#1379
giortzisg wants to merge 1 commit into
scopes/context-capturefrom
scopes/context-tracing

Conversation

@giortzisg

@giortzisg giortzisg commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

Issues

Changelog Entry Instructions

To add a custom changelog entry, uncomment the section above. Supports:

  • Single entry: just write text
  • Multiple entries: use bullet points
  • Nested bullets: indent 4+ spaces

For more details: custom changelog entries

Reminders

@giortzisg
giortzisg force-pushed the scopes/context-tracing branch from 5562df0 to 0e6bf84 Compare July 30, 2026 20:45
@giortzisg
giortzisg force-pushed the scopes/context-capture branch from efccd51 to c6716f7 Compare July 30, 2026 20:45
@linear-code

linear-code Bot commented Aug 3, 2026

Copy link
Copy Markdown

GO-154

@giortzisg
giortzisg force-pushed the scopes/context-capture branch from c6716f7 to 5af8a98 Compare August 4, 2026 15:25
@giortzisg
giortzisg force-pushed the scopes/context-tracing branch from 0e6bf84 to 09cf02b Compare August 4, 2026 15:25
@giortzisg giortzisg closed this Aug 4, 2026
@giortzisg giortzisg reopened this Aug 4, 2026
@giortzisg
giortzisg changed the base branch from scopes/context-capture to scopes/context-propagation-api August 4, 2026 15:37
@giortzisg
giortzisg force-pushed the scopes/context-propagation-api branch from eb9e225 to 1f41cd1 Compare August 4, 2026 15:42
@giortzisg
giortzisg force-pushed the scopes/context-tracing branch from 09cf02b to 388298c Compare August 4, 2026 15:42
@giortzisg
giortzisg force-pushed the scopes/context-propagation-api branch from 1f41cd1 to 675e68c Compare August 5, 2026 09:59
@giortzisg
giortzisg force-pushed the scopes/context-tracing branch from 388298c to 569c73b Compare August 5, 2026 09:59
@giortzisg
giortzisg force-pushed the scopes/context-propagation-api branch 2 times, most recently from 8108086 to a3ade00 Compare August 10, 2026 11:36
@giortzisg
giortzisg force-pushed the scopes/context-tracing branch from 569c73b to 580aec3 Compare August 10, 2026 11:36
@giortzisg
giortzisg changed the base branch from scopes/context-propagation-api to scopes/context-capture August 13, 2026 08:34
@giortzisg
giortzisg force-pushed the scopes/context-capture branch 2 times, most recently from 26a5f90 to 148a75b Compare August 13, 2026 12:54
@giortzisg
giortzisg force-pushed the scopes/context-tracing branch from 580aec3 to 75a6927 Compare August 24, 2026 07:53
@giortzisg
giortzisg marked this pull request as ready for review August 24, 2026 07:54
Comment thread hub.go
@giortzisg
giortzisg force-pushed the scopes/context-capture branch from 148a75b to 066ed7c Compare August 24, 2026 10:17
@giortzisg
giortzisg force-pushed the scopes/context-tracing branch from 75a6927 to bee39bc Compare August 24, 2026 10:17

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bee39bc. Configure here.

Comment thread hub.go
// hubFromContext returns either a hub stored in the context or the current hub.
// The return value is guaranteed to be non-nil, unlike GetHubFromContext.
func hubFromContext(ctx context.Context) *Hub {
func hubFromContext(ctx context.Context) *Hub { // nolint: unused

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hub baggage empty for new traces

High Severity

Removing scope SetSpan means hub.GetBaggage() no longer goes through span.ToBaggage() and only reads the propagation context DSC. For head-of-trace transactions that DSC is still empty when StartSpan copies it onto the scope, so GetBaggage() returns an empty string. Documented outgoing propagation and the no-span httpclient fallback then omit Sentry baggage, breaking downstream dynamic sampling.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit bee39bc. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant