feat: move tracing to rely on ctx - #1379
Conversation
5562df0 to
0e6bf84
Compare
efccd51 to
c6716f7
Compare
c6716f7 to
5af8a98
Compare
0e6bf84 to
09cf02b
Compare
eb9e225 to
1f41cd1
Compare
09cf02b to
388298c
Compare
1f41cd1 to
675e68c
Compare
388298c to
569c73b
Compare
8108086 to
a3ade00
Compare
569c73b to
580aec3
Compare
26a5f90 to
148a75b
Compare
580aec3 to
75a6927
Compare
148a75b to
066ed7c
Compare
75a6927 to
bee39bc
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bee39bc. Configure here.
| // hubFromContext returns either a hub stored in the context or the current hub. | ||
| // The return value is guaranteed to be non-nil, unlike GetHubFromContext. | ||
| func hubFromContext(ctx context.Context) *Hub { | ||
| func hubFromContext(ctx context.Context) *Hub { // nolint: unused |
There was a problem hiding this comment.
Hub baggage empty for new traces
High Severity
Removing scope SetSpan means hub.GetBaggage() no longer goes through span.ToBaggage() and only reads the propagation context DSC. For head-of-trace transactions that DSC is still empty when StartSpan copies it onto the scope, so GetBaggage() returns an empty string. Documented outgoing propagation and the no-span httpclient fallback then omit Sentry baggage, breaking downstream dynamic sampling.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit bee39bc. Configure here.


Description
Issues
context.Context#1367Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)