-
-
Notifications
You must be signed in to change notification settings - Fork 229
feat: Update error 413 handling
#4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| } | ||
|
|
||
| _options.ClientReportRecorder.RecordDiscardedEvents(DiscardReason.NetworkError, envelope); | ||
| _options.ClientReportRecorder.RecordDiscardedEvents(DiscardReason.SendError, envelope); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I read the docs correctly it is expected to now effectively change all NetworkError to SendError, see https://develop.sentry.dev/sdk/expected-features/#dealing-with-network-failures
If Sentry returns an HTTP 4xx or HTTP 5xx status code, SDKs:
MUST discard the envelope
MUST record a [client report](https://develop.sentry.dev/sdk/telemetry/client-reports/) with the discard reason send_error, except for an HTTP 429 response, see below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you're right.
Disambiguating the dev-docs via getsentry/sentry-docs#16152.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4863 +/- ##
==========================================
+ Coverage 73.83% 73.86% +0.03%
==========================================
Files 483 483
Lines 17559 17577 +18
Branches 3461 3464 +3
==========================================
+ Hits 12965 12984 +19
+ Misses 3742 3740 -2
- Partials 852 853 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sentry review |
jamescrosswell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bitsandfoxes !
Resolves #4861, getsentry/sentry-unity#2494