-
-
Notifications
You must be signed in to change notification settings - Fork 229
Network calls for Session Replay on Android #4860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
==========================================
- Coverage 73.86% 73.86% -0.01%
==========================================
Files 483 483
Lines 17577 17580 +3
Branches 3464 3465 +1
==========================================
+ Hits 12983 12985 +2
Misses 3741 3741
- Partials 853 854 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved most of this out to a separate PR as well, since it's just a means to an end to diagnose the problem (not actually part of the change this PR is meant to effect):
… .NET and Java replay breadcrumbs
Resolves #4192:
This PR ensures performanceSpans are sent with replay events so that outbound network requests in Maui for Android are displayed correctly in the
Replay -> Networktab.Implementation notes
The performanceSpan itself doesn't include a replyId, so it has to be sent along with the replay event - i.e. it gets sent by the mobile/Android SDK. The way android does this is to inspect the stream of breadcrumbs and convert these into RRWeb custom events. Typicallly this is done via the DefaultBreadcrumbConverter but it's also possible to swap that out with a custom converter (which is what our ReactNative SDK does).
This PR is an attempt to utilise the
DefaultReplayBreadcrumbConverterby ensuring that our breadcrumbs contain all the data properties it's expecting.Additional comments
If we eventually try to implement this for iOS, iOS looks for slightly different field names