Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Jan 22, 2026

Resolves #4192:

This PR ensures performanceSpans are sent with replay events so that outbound network requests in Maui for Android are displayed correctly in the Replay -> Network tab.

image

Implementation notes

The performanceSpan itself doesn't include a replyId, so it has to be sent along with the replay event - i.e. it gets sent by the mobile/Android SDK. The way android does this is to inspect the stream of breadcrumbs and convert these into RRWeb custom events. Typicallly this is done via the DefaultBreadcrumbConverter but it's also possible to swap that out with a custom converter (which is what our ReactNative SDK does).

This PR is an attempt to utilise the DefaultReplayBreadcrumbConverter by ensuring that our breadcrumbs contain all the data properties it's expecting.

Additional comments

If we eventually try to implement this for iOS, iOS looks for slightly different field names

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.86%. Comparing base (5dde625) to head (e7b460b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4860      +/-   ##
==========================================
- Coverage   73.86%   73.86%   -0.01%     
==========================================
  Files         483      483              
  Lines       17577    17580       +3     
  Branches     3464     3465       +1     
==========================================
+ Hits        12983    12985       +2     
  Misses       3741     3741              
- Partials      853      854       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamescrosswell jamescrosswell changed the title Initial commit Network calls for Session Replay on Android Jan 23, 2026
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved most of this out to a separate PR as well, since it's just a means to an end to diagnose the problem (not actually part of the change this PR is meant to effect):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android Session Replay - Add network calls

3 participants