fix(docs): Remove totally destructive flag from troubleshooting guide#18251
Open
jkrshw wants to merge 1 commit into
Open
fix(docs): Remove totally destructive flag from troubleshooting guide#18251jkrshw wants to merge 1 commit into
jkrshw wants to merge 1 commit into
Conversation
The "hard recovery" option indicates that some data will be lost. However, the first instruction is to take down all services with the `--volume` flag which instructs docker to destroy _all_ named volumes, resulting in total data loss. The second step to remove just the `sentry-kafka` volume would be redundant since all volumes have been removed. This change removes the `--volume` option so that only the `sentry-kafka` volume will be removed. I have confirmed this fixed my issue without total data loss.
|
@jkrshw is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
jkrshw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The "hard recovery" option in the Offset Out Of Range Error guide indicates that some data will be lost. However, the first instruction is to take down all services with the
--volumeflag which instructs docker to destroy all named volumes, resulting in total data loss.The second step to remove just the
sentry-kafkavolume would be redundant since all volumes have been removed.This change removes the
--volumeoption so that only thesentry-kafkavolume will be removed. I have confirmed this fixed my issue without total data loss.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES