docs(go): Update Echo guide for v5 and TracesSampler SamplingContext#17377
Open
docs(go): Update Echo guide for v5 and TracesSampler SamplingContext#17377
Conversation
Echo v5 changed handler signatures from echo.Context to *echo.Context (pointer). Update all code examples in the Echo guide accordingly. TracesSampler gained two new SamplingContext fields: - ParentSampled: covers both local and remote parent sampling decisions, replacing the previous pattern of checking ctx.Parent != nil. - ParentSampleRate: the sample rate from the parent's Dynamic Sampling Context. Update the default-sampling-context-platform and always-inherit-sampling-decision includes to reflect these additions. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…ler example The previous example only used ctx.ParentSampled, which reads as remote-only. Show the two cases separately: ctx.Parent for local spans (same process) and ctx.ParentSampled for remote spans (upstream service). Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Updates Go SDK docs to reflect two changes from recent sentry-go releases:
Echo v5 (getsentry/sentry-go#1183)
echo.Context(interface) to*echo.Context(pointer)*echo.ContextTracesSampler SamplingContext fields (getsentry/sentry-go#1259)
SamplingContextgained two new fields:ParentSampledandParentSampleRateParentSampledworks for both local and remote parent spans, replacing the oldctx.Parent != nilpatternParentSampleRateexposes the sample rate from the parent's Dynamic Sampling Contextdefault-sampling-context-platform/go.mdxwith the new struct definitionalways-inherit-sampling-decision/go.mdxto usectx.ParentSampledinstead ofctx.Parent.SampledIS YOUR CHANGE URGENT?
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST