-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(sdk): add Hub/Scope and Client steps to metrics and logs #16457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
philipphofmann
wants to merge
4
commits into
master
Choose a base branch
from
philipp/docs-sdk-metrics-hub-scope
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1042e86
docs(sdk): add Hub/Scope steps to metrics SDK behavior
philipphofmann 2638c36
Merge branch 'master' into philipp/docs-sdk-metrics-hub-scope
philipphofmann b11437a
Merge branch 'master' into philipp/docs-sdk-metrics-hub-scope
philipphofmann f4c617f
docs(sdk): use generic captureMetric/captureLog for Hub/Scope
philipphofmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -125,7 +125,7 @@ Log processing **MUST** follow this order: | |
|
|
||
| 1. Capture log via [Public APIs](#logger-module) (e.g. `Sentry.logger.info`) or via [SDK integrations](#sdk-integrations). | ||
| 2. Check if logging is enabled via `enableLogs`/`enable_logs` — if not, skip remaining steps. | ||
| 3. Pass the log to Hub/Scope, which **MUST** offer the same methods as the static API `Sentry.logger.X`. | ||
| 3. Pass the log to Hub/Scope via a generic method (e.g., `captureLog(log, scope)`). | ||
| 4. Pass the log to the Client via a generic method (e.g., `captureLog(log, scope)`). | ||
| 5. Process captured log (attach attributes per [Default Attributes](#default-attributes)). | ||
| 6. Run `beforeSendLog`/`before_send_log` to filter or modify the log. | ||
|
|
@@ -461,9 +461,11 @@ SDKs **MUST** expose logging methods in a `logger` module or namespace, with one | |
|
|
||
| These methods accept a string template and parameters for structured logging. They **MAY** also accept arbitrary attributes. | ||
|
|
||
| The Hub/Scope **MUST** offer the same methods as the static `Sentry.logger.X` API (since 1.10.0). The Client **SHOULD** only offer one generic method (e.g., `captureLog(log, scope)`). | ||
| Furthermore: | ||
|
|
||
| SDKs **MAY** add additional helpers (e.g., decorators, string template helpers) as appropriate for their platform. | ||
| 1. The Hub/Scope and Client **MUST** offer a generic method for capturing logs (e.g., `captureLog(log, scope)`). | ||
| 1. The Hub/Scope **MAY** offer the same methods as the static `Sentry.logger.X` API (since 1.10.0). | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, we do not want this. |
||
| 1. SDKs **MAY** add additional helpers (e.g., decorators, string template helpers) as appropriate for their platform. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not precise enough. We will get questions in a month what this means. |
||
|
|
||
| </SpecSection> | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no e.g., this has to be called
captureLog. Not sure why scope would be a parameter in general, should likely bescope.captureLog()