Skip to content

chore: declare Python 3.14 classifier - #810

Open
ltsyk wants to merge 8 commits into
getsentry:masterfrom
ltsyk:chore/declare-python-3.14-classifiers
Open

chore: declare Python 3.14 classifier#810
ltsyk wants to merge 8 commits into
getsentry:masterfrom
ltsyk:chore/declare-python-3.14-classifiers

Conversation

@ltsyk

@ltsyk ltsyk commented Jul 30, 2026

Copy link
Copy Markdown

Summary

Declare Python 3.14 in package classifiers (tox already lists py314; issue #793).

Fixes #793

Declare Python 3.14 support classifiers (issue getsentry#793)
@ltsyk
ltsyk requested a review from markstory as a code owner July 30, 2026 07:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit fcceda3. Configure here.

Comment thread tox.ini.bak Outdated
@ltsyk

ltsyk commented Aug 1, 2026

Copy link
Copy Markdown
Author

Removed the accidental tox.ini.bak that snuck into the branch; the PR now only adds the 3.14 classifier (and the intentional tox.ini envlist update).

@beliaev-maksim

Copy link
Copy Markdown
Collaborator

can you please also update CI file to include it in the tests, as well as CHANGES file

Comment thread tox.ini
@@ -1,5 +1,5 @@
[tox]
envlist = py38,py39,py310,py311,py312,py313,mypy,precom
envlist = py38,py39,py310,py311,py312,py313,py314,mypy,precom

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need to enable it in CI

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — added a CHANGES entry for 3.14. tox already has py314; I also tried to add 3.14 to .github/workflows/ci.yml but this token cannot update workflow files. A maintainer with workflow scope will need to add '3.14' to the test matrix there.

@ltsyk

ltsyk commented Sep 2, 2026

Copy link
Copy Markdown
Author

Thanks — I added a CHANGES note for Python 3.14 support. tox envlist already includes py314. I cannot update .github/workflows/ci.yml from this token (workflow files 404); please add '3.14' to the CI test matrix when you can.

Comment thread CHANGES Outdated
Comment thread CHANGES Outdated
* Fixed regression with `stream` parameter deprecation, requests.session() and cookie handling.
* Replaced adhoc URL parsing with `urllib.parse`.
* Added ``match`` parameter to ``add_callback`` method
* Added ``match`` parameter to ``add_callback` method

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added ``match`` parameter to ``add_callback` method
* Added ``match`` parameter to ``add_callback`` method

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied, thanks.

Comment thread CHANGES
Comment on lines +5 to +8
* Added a ``keep_headers`` argument to ``_recorder.record`` and
``Recorder.dump_to_file`` to preserve named headers (for example ``Date``)
that are otherwise stripped as verbose defaults, so a signed response can be
recorded and later verified. Matching is case-insensitive. See #763

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The changelog documents a keep_headers argument for _recorder.record and Recorder.dump_to_file, but the feature is not implemented, causing a TypeError when used.
Severity: MEDIUM

Suggested Fix

Either implement the keep_headers functionality or remove its documentation from the CHANGES file. To implement it, add the keep_headers parameter to the record and dump_to_file function signatures. Then, modify the _remove_default_headers function to check against the keep_headers list and prevent the specified headers from being stripped.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: CHANGES#L5-L8

Potential issue: The changelog file documents a new `keep_headers` argument for the
`_recorder.record` and `Recorder.dump_to_file` functions, intended to preserve specific
headers. However, this feature is not implemented in the code. The function signatures
for `record` and `dump_to_file` do not accept a `keep_headers` argument. Consequently,
any attempt to use this documented feature, such as
`_recorder.record(keep_headers=['Date'])`, will result in a `TypeError` at runtime
because the function receives an unexpected keyword argument. The header stripping logic
is also hardcoded and does not account for this parameter.

Keep the 3.14 changelog bullet alongside master's keep_headers note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tox support for Python 3.14

3 participants