chore: declare Python 3.14 classifier - #810
Conversation
Declare Python 3.14 support classifiers (issue getsentry#793)
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fcceda3. Configure here.
|
Removed the accidental |
|
can you please also update CI file to include it in the tests, as well as CHANGES file |
| @@ -1,5 +1,5 @@ | |||
| [tox] | |||
| envlist = py38,py39,py310,py311,py312,py313,mypy,precom | |||
| envlist = py38,py39,py310,py311,py312,py313,py314,mypy,precom | |||
There was a problem hiding this comment.
also need to enable it in CI
There was a problem hiding this comment.
Thanks — added a CHANGES entry for 3.14. tox already has py314; I also tried to add 3.14 to .github/workflows/ci.yml but this token cannot update workflow files. A maintainer with workflow scope will need to add '3.14' to the test matrix there.
|
Thanks — I added a CHANGES note for Python 3.14 support. tox envlist already includes py314. I cannot update |
| * Fixed regression with `stream` parameter deprecation, requests.session() and cookie handling. | ||
| * Replaced adhoc URL parsing with `urllib.parse`. | ||
| * Added ``match`` parameter to ``add_callback`` method | ||
| * Added ``match`` parameter to ``add_callback` method |
There was a problem hiding this comment.
| * Added ``match`` parameter to ``add_callback` method | |
| * Added ``match`` parameter to ``add_callback`` method |
| * Added a ``keep_headers`` argument to ``_recorder.record`` and | ||
| ``Recorder.dump_to_file`` to preserve named headers (for example ``Date``) | ||
| that are otherwise stripped as verbose defaults, so a signed response can be | ||
| recorded and later verified. Matching is case-insensitive. See #763 |
There was a problem hiding this comment.
Bug: The changelog documents a keep_headers argument for _recorder.record and Recorder.dump_to_file, but the feature is not implemented, causing a TypeError when used.
Severity: MEDIUM
Suggested Fix
Either implement the keep_headers functionality or remove its documentation from the CHANGES file. To implement it, add the keep_headers parameter to the record and dump_to_file function signatures. Then, modify the _remove_default_headers function to check against the keep_headers list and prevent the specified headers from being stripped.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: CHANGES#L5-L8
Potential issue: The changelog file documents a new `keep_headers` argument for the
`_recorder.record` and `Recorder.dump_to_file` functions, intended to preserve specific
headers. However, this feature is not implemented in the code. The function signatures
for `record` and `dump_to_file` do not accept a `keep_headers` argument. Consequently,
any attempt to use this documented feature, such as
`_recorder.record(keep_headers=['Date'])`, will result in a `TypeError` at runtime
because the function receives an unexpected keyword argument. The header stripping logic
is also hardcoded and does not account for this parameter.
Keep the 3.14 changelog bullet alongside master's keep_headers note.

Summary
Declare Python 3.14 in package classifiers (tox already lists py314; issue #793).
Fixes #793