Skip to content

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Dec 24, 2025

This is an ongoing effort to simplify the release process to not rely on the hacky GitHub Actions script that copies the Docker image after a release was created.

Part of getsentry/self-hosted#4123

REF SELF-78

#skip-changelog

brain getting to much work
@aldy505 aldy505 requested a review from a team as a code owner December 24, 2025 12:37
@aldy505 aldy505 requested review from BYK and hubertdeng123 December 24, 2025 12:37
Comment on lines +5 to +9
statusProvider:
name: github
config:
contexts:
- "Build Docker Image (relay)"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The .craft.yml configuration waits for a GitHub status check "Build Docker Image (relay)", but the workflow providing it is being removed, causing a release deadlock.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The .craft.yml file is configured with a statusProvider that waits for a GitHub status check named "Build Docker Image (relay)". However, the pull request removes the .github/workflows/release-ghcr-version-tag.yml workflow, which was the likely source for this status check. No other workflow in the repository is configured to produce a check with this specific name. As a result, the Craft release process will hang indefinitely or time out while waiting for a status check that will never be created, effectively blocking all releases.

💡 Suggested Fix

Update the statusProvider configuration in .craft.yml to wait for a status check that is produced by an existing workflow, or modify an existing workflow to produce the required "Build Docker Image (relay)" status check.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .craft.yml#L5-L9

Potential issue: The `.craft.yml` file is configured with a `statusProvider` that waits
for a GitHub status check named `"Build Docker Image (relay)"`. However, the pull
request removes the `.github/workflows/release-ghcr-version-tag.yml` workflow, which was
the likely source for this status check. No other workflow in the repository is
configured to produce a check with this specific name. As a result, the Craft release
process will hang indefinitely or time out while waiting for a status check that will
never be created, effectively blocking all releases.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7908621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant