Skip to content

Revert "fix(docker): Split CMD into ENTRYPOINT + CMD for multi-mode s… #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 1 commit into from
Mar 27, 2026
+5 −7
Merged

Revert "fix(docker): Split CMD into ENTRYPOINT + CMD for multi-mode s… #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ jobs:
-e KAFKA_BOOTSTRAP_SERVERS="kafka:9093" \
-e KAFKA_GROUP_ID="launchpad-test-ci" \
-e KAFKA_TOPICS="preprod-artifact-events" \
--entrypoint python launchpad-test -m pytest -n auto tests/ --ignore=tests/e2e -v
launchpad-test python -m pytest -n auto tests/ --ignore=tests/e2e -v

- name: Show Kafka logs on failure
if: failure()
Expand All @@ -133,7 +133,7 @@ jobs:
-e LAUNCHPAD_ENV=development \
-e LAUNCHPAD_HOST=localhost \
-e LAUNCHPAD_PORT=2218 \
launchpad-test --help
launchpad-test launchpad --help

e2e:
runs-on: ubuntu-latest
Expand Down
7 changes: 2 additions & 5 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build libdispatch for the strip binary
FROM --platform=linux/amd64 debian:12-slim AS libdispatch-build

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-arm64

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / build-amd64

FROM --platform flag should not use a constant value 

FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64"
More info: https://docs.docker.com/go/dockerfile/rule/from-platform-flag-const-disallowed/

RUN apt-get update && apt-get install -y --no-install-recommends \
build-essential \
Expand Down Expand Up @@ -112,8 +112,5 @@
ARG LAUNCHPAD_VERSION_SHA
ENV LAUNCHPAD_VERSION_SHA=$LAUNCHPAD_VERSION_SHA

# ENTRYPOINT/CMD split allows K8s deployments to override the subcommand via `args`.
# - Serve mode (deployment.yaml): uses default CMD -> "launchpad serve"
# - Worker mode (taskworker-deployment.yaml): overrides CMD via args -> "launchpad worker ..."
ENTRYPOINT ["launchpad"]
CMD ["serve"]
# Default command
CMD ["launchpad", "serve"]
1 change: 1 addition & 0 deletions devservices/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ services:
ports:
- 127.0.0.1:2218:2218 # Bind to localhost only - no external access
command:
- launchpad
- serve
- --verbose
healthcheck:
Expand Down
Loading