fix(docker): Split CMD into ENTRYPOINT + CMD for multi-mode support#588
Merged
NicoHinderling merged 3 commits intomainfrom Mar 27, 2026
Merged
fix(docker): Split CMD into ENTRYPOINT + CMD for multi-mode support#588NicoHinderling merged 3 commits intomainfrom
NicoHinderling merged 3 commits intomainfrom
Conversation
The Dockerfile used CMD ["launchpad", "serve"] with no ENTRYPOINT. The taskworker K8s deployment overrides args to run the worker subcommand, but without an ENTRYPOINT this replaces the entire command instead of just the arguments. Split into ENTRYPOINT ["launchpad"] + CMD ["serve"] so the serve deployment uses the default and the taskworker deployment can override CMD via K8s args to run "launchpad worker". Co-Authored-By: Claude <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Co-Authored-By: Claude <noreply@anthropic.com>
Docker Compose `command` and `docker run` args override CMD but not ENTRYPOINT, so references that included "launchpad" as the first arg would result in "launchpad launchpad ...". Drop the leading "launchpad" from devservices config and CI workflow, and use --entrypoint for the pytest docker run. Co-Authored-By: Claude <noreply@anthropic.com>
trevor-e
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Dockerfile used
CMD ["launchpad", "serve"]with noENTRYPOINT. The taskworker K8s deployment overridesargsto run the worker subcommand (taskworker-deployment.yaml#L199-L201), but without anENTRYPOINTthis replaces the entire command instead of just the arguments — causing the container to try to executeworkeras a bare command.Split into
ENTRYPOINT ["launchpad"]+CMD ["serve"]so:deployment.yaml#L123) uses the default →launchpad servetaskworker-deployment.yaml#L197-L201) overrides CMD via K8sargs→launchpad worker --processing-pool-name ...Also updates
devservices/config.ymland CI workflow to account for the newENTRYPOINT— Docker Composecommandanddocker runargs override CMD but not ENTRYPOINT, so the leadinglaunchpadis dropped where it would duplicate.No changes needed in the ops repo — both deployments are already structured correctly for this pattern.