chore(lint): enforce command output conventions via Biome plugins#439
Merged
chore(lint): enforce command output conventions via Biome plugins#439
Conversation
Add lint rules to enforce PR #433 buildCommand conventions: - GritQL plugins ban stdout.write() and process.stdout in command files (src/commands/), using file()-scoped patterns that produce inline editor diagnostics and run as part of bun run lint. - noRestrictedImports override bans chalk in command files, directing to colorTag() from the markdown rendering pipeline. - Fix muted() usage in issue/view.ts to respect NO_COLOR and SENTRY_PLAIN_OUTPUT via the isPlainOutput() pattern.
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Init
Issue List
Other
Bug Fixes 🐛Dsn
Init
Other
Documentation 📚
Internal Changes 🔧Init
Tests
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ 111 passed | Total: 111 | Pass Rate: 100% | Execution Time: 0ms 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 1101 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 95.06% 95.05% -0.01%
==========================================
Files 164 164 —
Lines 22254 22254 —
Branches 0 0 —
==========================================
+ Hits 21154 21153 -1
- Misses 1100 1101 +1
- Partials 0 0 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce PR #433
buildCommandconventions via lint rules that run as part ofbun run lint:GritQL Plugins (new)
Two Biome GritQL plugins in
lint-rules/ban anti-patterns insrc/commands/:no-stdout-write-in-commands— commands should yieldCommandOutput, not callstdout.write()directlyno-process-stdout-in-commands— commands should not accessprocess.stdoutBoth use
file($name, $body)scoping so they only fire on command files and produce inline editor diagnostics.noRestrictedImports (new)
Biome override bans
chalkimports insrc/commands/**/*.ts, directing developers tocolorTag()from the markdown rendering pipeline which respectsNO_COLOR/SENTRY_PLAIN_OUTPUT.Bug fix
Fix
muted()usage insrc/commands/issue/view.tsto use theisPlainOutput()pattern, so span-tree fallback messages don't leak ANSI codes in plain-output mode.