fix(error-reporting): Silence SeerError as feature_disabled - #1505
Closed
sentry[bot] wants to merge 2 commits into
Closed
fix(error-reporting): Silence SeerError as feature_disabled#1505sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Closing with the same reason from the other PR: "This is intentional to track demand." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue CLI-1WP where
SeerError: Seer is not enabled for this organization.was being captured as an actionable Sentry issue, despite being an expected feature-gate condition.The root cause was that
classifySilenced()inpackages/cli/src/lib/error-reporting.tsdid not recognizeSeerErroras a silenceable error. This led to these errors being reported to Sentry as if they were unexpected CLI bugs.This fix re-implements the solution from a previous unmerged PR (#1308):
'feature_disabled'to theSilenceReasonunion type.classifySilenced()to return'feature_disabled'when anerror instanceof SeerError.This ensures that
SeerErrorinstances are correctly silenced and recorded ascli.error.silencedmetrics, rather than being captured as Sentry issues.Unit tests in
test/lib/error-reporting.test.tshave been updated to reflect this new silencing behavior.Fixes CLI-1WP
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.