-
-
Notifications
You must be signed in to change notification settings - Fork 267
feat(tools)!: Standardize launch arguments #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking removal of
argsinput on launch-only tools not recorded under a Breaking sectionThe PR title declares a breaking tool contract change (
feat(tools)!:) and the entry itself states launch-only toolsno longer use generic args, which removes a previously supported input field. The[Unreleased]section only containsAdded/Fixed/Changed, while the prior[2.5.0-beta.1]release uses a### Breakingsubsection for analogous tool-contract changes. Release notes generated from this section viascripts/generate-github-release-notes.mjswill not surface this as a breaking change, leaving users unaware that callers passingargstolaunch_app_sim/launch_app_device/launch_mac_appwill break.Verification
Read CHANGELOG.md lines 1-60 to confirm the
[Unreleased]section lacks a### Breakingsubsection and compared against the[2.5.0-beta.1]section which uses### Breakingfor removed tool inputs. Cross-referenced the PR titlefeat(tools)!:(conventional-commit breaking marker) and the entry text stating launch-only toolsno longer use generic args, which is a removal of a previously accepted input.Identified by Warden
xcodebuildmcp-docs-release-review·REY-VM5There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix attempt detected (commit 402f423)
The commit added documentation about the breaking change (removal of generic
argsfrom launch-only tools) to the Added section at line 10, but failed to create a dedicated### Breakingsubsection in the [Unreleased] section as required to properly surface this as a breaking change in generated release notes.The original issue appears unresolved. Please review and try again.
Evaluated by Warden