Skip to content

Allow the mixing of rename and default var; fixes #587 #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuzicheng1987 merged 2 commits into from
Jan 28, 2026
+9 −1
Merged

Allow the mixing of rename and default var; fixes #587 #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a191994
Allow the mixing of rename and default var
liuzicheng1987 Jan 27, 2026
a28c856
Minor tweaks
liuzicheng1987 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/rfl/internal/is_default_val_v.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
#include <type_traits>

#include "../DefaultVal.hpp"
#include "../Rename.hpp"
#include "StringLiteral.hpp"

namespace rfl::internal {

Expand All @@ -16,6 +18,10 @@ class is_default_val : public std::false_type {};
template <class T>
class is_default_val<DefaultVal<T>> : public std::true_type {};

template <class T, internal::StringLiteral _new_name>
class is_default_val<Rename<_new_name, DefaultVal<T>>> : public std::true_type {
};

template <class T>
constexpr bool is_default_val_v =
is_default_val<std::remove_cvref_t<std::remove_pointer_t<T>>>::value;
Expand Down
4 changes: 3 additions & 1 deletion tests/json/test_default_val.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ struct Person {
std::string first_name;
rfl::DefaultVal<std::string> last_name = "Simpson";
rfl::DefaultVal<std::string> town;
rfl::Rename<"country", rfl::DefaultVal<std::string>> home_country = "USA";
};

TEST(json, test_default_val) {
Expand All @@ -28,9 +29,10 @@ TEST(json, test_default_val) {
EXPECT_EQ(homer.first_name, "Homer");
EXPECT_EQ(homer.last_name.value(), "Simpson");
EXPECT_EQ(homer.town.value(), "");
EXPECT_EQ(homer.home_country().value(), "USA");

write_and_read(
Person{"Waylon", "Smith", "Springfield"},
R"({"first_name":"Waylon","last_name":"Smith","town":"Springfield"})");
R"({"first_name":"Waylon","last_name":"Smith","town":"Springfield","country":"USA"})");
}
} // namespace test_default_val
Loading