Open
Conversation
D1353L
reviewed
Apr 8, 2026
| total_amount_cents: Optional[int] | ||
| unit_amount_cents: Optional[int] # deprecated | ||
| precise_unit_amount: Optional[str] | ||
| sub_total_excluding_taxes_amount_cents: Optional[int] |
Contributor
There was a problem hiding this comment.
I see a pattern here that all fields are Optional, but it may be worth revising. Because it's not consistent with other models
D1353L
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
sub_total_excluding_taxes_amount_centsandsub_total_excluding_taxes_precise_amount_centsare added in the fee response.Description
This PR supports those two recently added attributes.