Sw/include method source in appmap #278
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I believe this pr is superseded by #279 which includes only the |
Contributor
Author
|
If so, please close it.
…On Thu, Sep 15, 2022 at 8:04 AM symwell ***@***.***> wrote:
I believe this pr is superseded by #279
<#279> which includes only
the method_source source code AppMap uses.
—
Reply to this email directly, view it on GitHub
<#278 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVC6Z4S6373J73ZVRX3XDV6MGELANCNFSM6AAAAAAQI5P6DE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the code to get the source code of the function - and it's also horribly inefficient. So, you can remove that along with its test cases.