feat(doctor): probeRoots for 12 more providers (#899 Tier 1) - #903
Open
ozymandiashh wants to merge 1 commit into
Open
feat(doctor): probeRoots for 12 more providers (#899 Tier 1)#903ozymandiashh wants to merge 1 commit into
ozymandiashh wants to merge 1 commit into
Conversation
Each implementation calls the exact resolution helpers its provider's discovery uses (same env fallbacks, same OS branches, same closure overrides), so doctor reports precisely where discovery looks and a stale override or moved data dir stops being a silent $0.00. lingtai-tui deliberately reports its candidates pre-existence-filter: getLingTaiHomes drops non-existent dirs (right for discovery, wrong for doctor, whose job is to show where it looked). tests/provider-probe-roots.test.ts locks the mirroring: where a factory takes an override, the same override must come back through probeRoots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tier 1 of #899:
probeRoots()for the 12 uncovered providers from thePROVIDER_ENV_VARSlist - codewhale, hermes, lingtai-tui, droid, cursor, cursor-agent, goose, crush, warp, antigravity, qwen, ibm-bob. Coverage goes 6/42 to 18/42.Every implementation calls the exact resolution helpers its discovery path uses (same env fallbacks, OS branches, and factory overrides), verified per provider against the discovery code. One deliberate divergence, commented in the code: lingtai-tui reports its candidates BEFORE the existence filter, because
getLingTaiHomesdropping non-existent dirs is right for discovery and wrong for doctor, whose job is to show where it looked.Verification:
tests/provider-probe-roots.test.ts(12 cases): wherever a factory takes an override, the SAME override must come back through probeRoots, proving the two paths share one resolution. 12/12 green,tsc --noEmitclean.codeburn doctorrun on my machine, before/after visible in one table: covered providers now print the exact path checked (Droid - NOTHING FOUND (~/.factory/sessions does not exist; tool likely not installed),Crush - .../crush/projects.json does not exist,Cursor Agent - projects + ai-tracking db, exists), while the still-uncovered ones keep the generic "tool likely not installed or no history yet" row. That generic row is the remaining Tier 2 target list.Refs #899 (does not close it; Tier 2 remains).