test(cli-proxy-path): fix load-timeout flake by raising the test timeout#504
Merged
Conversation
… flake Each test spawns 'tsx src/cli.ts' several times, re-transpiling the CLI on every spawn. Under full-suite parallel load these spawns contend for CPU and the slowest test could exceed the 5s default timeout, even though it runs in ~1.7s in isolation and the spawnSync calls already allow 30s each. Set the file testTimeout to 30s so the wrapper matches the per-spawn cap. Full suite is green across repeated runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tests/cli-proxy-path.test.tsspawnstsx src/cli.tsseveral times per test, which re-transpiles the CLI on every spawn. Under full-suite parallel load those spawns contend for CPU, so the slowest test occasionally exceeded the 5s default test timeout, even though it runs in ~1.7s in isolation and eachspawnSyncalready allows 30s.Fix
Set the file-level
testTimeoutto 30s (viavi.setConfig), matching the existing per-spawn cap. Spawn-based integration tests are inherently slower than unit tests and shouldn't be held to the 5s default. No test logic changed.Verification
cli-proxy-pathintermittently timed out under load).