Skip to content

menubar: status-item recovery pulses all fire when the menu bar is persistent - #1461

Merged
iamtoruk merged 1 commit into
mainfrom
fix/menubar-status-item-visible
Sep 16, 2026
Merged

iamtoruk merged 1 commit into
mainfrom
fix/menubar-status-item-visible

Conversation

@iamtoruk

Copy link
Copy Markdown
Member

Found while diagnosing #1148. The recovery loop from #1161 that re-places a parked status item only worked when the menu bar auto-hides. On a persistent menu bar the reveal check is always true, so the hide gate never cleared: one pulse fired, retries two and three never ran, and the loop woke every 250ms for the rest of its two-minute window, about 477 no-op wakeups per launch.

Now the gate arms only when the menu bar can actually hide. Persistent bar: three pulses about 800ms apart, loop ends at about 2.4s. Auto-hide bar: unchanged.

  • Two new tests; the persistent-bar test fails with the gate reverted.
  • swift build clean, swift test 671 passing, localization coverage green, no strings changed.
  • Independently reviewed: the only semantic change is the one gate line, the rest is extraction.

Does not by itself close #1148, whose remaining cause is system-side status-item state; the reporter has been asked for the two diagnostics.

@iamtoruk
iamtoruk merged commit bf06d6c into main Sep 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS: menubar status item never appears - per-bundle-id state can be permanently poisoned (survives reinstall and reboot)

1 participant