menubar: status-item recovery pulses all fire when the menu bar is persistent - #1461
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while diagnosing #1148. The recovery loop from #1161 that re-places a parked status item only worked when the menu bar auto-hides. On a persistent menu bar the reveal check is always true, so the hide gate never cleared: one pulse fired, retries two and three never ran, and the loop woke every 250ms for the rest of its two-minute window, about 477 no-op wakeups per launch.
Now the gate arms only when the menu bar can actually hide. Persistent bar: three pulses about 800ms apart, loop ends at about 2.4s. Auto-hide bar: unchanged.
swift buildclean,swift test671 passing, localization coverage green, no strings changed.Does not by itself close #1148, whose remaining cause is system-side status-item state; the reporter has been asked for the two diagnostics.