Add new subcommand: mosh #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
reviewed
May 16, 2019
geofrontcli/cli.py
Outdated
| except ValueError as e: | ||
| mosh.error(str(e)) | ||
| command = [args.mosh] + options | ||
| print(command) |
Contributor
There was a problem hiding this comment.
This seems a debug print and left by mistake.
dahlia
approved these changes
May 16, 2019
kanghyojun
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mosh is a remote terminal emulator like SSH, with better experience on mobile network.
Even though it's intended to be a replacement for SSH, Command line parameter of
moshis incompatible withssh's. For this reason,-Soption can't be used to launch Mosh client viageofront-cli. That is the reason why I suggest to introduce a new command for Mosh especially.