Repository navigation
feat(auth): guided Argon2id password-hash upgrade for existing accounts - #41
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an optional, accessible confirmation modal and persistent reminder in the first-party /account/security page for users whose local password hash requires Argon2id migration. Authenticated GET /account/password/upgrade reports status; same-origin HTTPS POST requires the current password and upgrades with PostgreSQL compare-and-swap. Preserve all existing sessions, MFA data, password values and changed_at_ms; reject stale credentials and simultaneous password resets. External-only accounts, up-to-date accounts and installations retaining scrypt default are not prompted. Tests cover password mismatch, idempotent upgrades and PostgreSQL KDF migration; deployment must wait for green CI and a separate browser/login smoke test.
Rollout guardrail
The live OpenProof service is not modified. Enable Argon2id preference only after this version is safely deployed, tested and backed up. The popup collects passwords only at the OpenProof origin; connected applications should link to it rather than handle credentials.