Repository navigation
fix(sdk): align redirect URI validation with OpenProof server - #38
Merged
Merged
Conversation
thecompez
marked this pull request as ready for review
October 9, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
OpenProof C++ registration accepts HTTPS redirect URIs or native IP-loopback HTTP callbacks with an explicit port. The JavaScript SDK accepted remote HTTP and unsupported URI schemes, allowing misconfigured integrations that the server would later reject.
Fix
Validation
Compatibility note
This intentionally rejects custom-scheme URLs that were previously accepted by the SDK constructor but are not registerable with the current OpenProof server. Keep as draft until reviewed and CI passes.
No production deployment or restart.