Skip to content

fix(sdk): reject unsafe redirect URIs and duplicate OAuth callback params - #36

Merged
thecompez merged 1 commit into
mainfrom
audit/sdk-callback-validation-20261009
Oct 8, 2026
Merged

thecompez merged 1 commit into
mainfrom
audit/sdk-callback-validation-20261009

Conversation

@thecompez

Copy link
Copy Markdown
Member

Changes

  • Reject javascript:, data:, and file: redirect URI schemes, and redirect URIs with fragments.
  • Reject duplicate code, state, or iss OAuth callback parameters rather than silently processing the first occurrence.
  • Preserve custom native-app URI schemes.

Regression tests

  • New negative config tests and duplicate callback query tests fail against pre-fix SDK.
  • node sdk/javascript/test.mjs — passed after fix.
  • python3 scripts/verify-openapi.py — passed (87 paths, 111 operations).
  • git diff --check — passed.

Operational safety

  • SDK-only change in an isolated worktree from origin/main.
  • No changes to production binaries, server config, database, running services, or application deployment.
  • Review CI before marking ready or merging.

@thecompez
thecompez marked this pull request as ready for review October 8, 2026 23:43
@thecompez
thecompez merged commit 0ce0409 into main Oct 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant